Skip to content

'Undefined offset:' notices in post classes #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

d8y
Copy link

@d8y d8y commented Jun 7, 2021

Error depending on font used when using Laravel dom pdf
The issue that has been raised is #63

#57 is up as a solution to a similar problem.

I want to avoid the error by checking the existence of the same.

@bsweeney
Copy link
Member

bsweeney commented Jun 8, 2021

The referenced PR may have resolved a similar PHP error, but the solution implemented there is not appropriate here. You're falling back to "0" in the case where the index doesn't exist, but the value being determined is not numeric. The value should be the name of the related glyph.

Based on how this value is used I believe it would be more appropriate to only set a value in the $names array if a glyph name is present (ref1) (ref2).

I went ahead and implemented this change in #90. Please review and comment there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants