'Undefined offset:' notices in post classes #89
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The referenced PR may have resolved a similar PHP error, but the solution implemented there is not appropriate here. You're falling back to "0" in the case where the index doesn't exist, but the value being determined is not numeric. The value should be the name of the related glyph. Based on how this value is used I believe it would be more appropriate to only set a value in the $names array if a glyph name is present (ref1) (ref2). I went ahead and implemented this change in #90. Please review and comment there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error depending on font used when using Laravel dom pdf
The issue that has been raised is #63
#57 is up as a solution to a similar problem.
I want to avoid the error by checking the existence of the same.