Skip to content

'Undefined offset:' notices in loca and htmx classes #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2017
Merged

'Undefined offset:' notices in loca and htmx classes #57

merged 1 commit into from
Aug 31, 2017

Conversation

mondrake
Copy link
Contributor

In the test suite of a Drupal module that uses this library (https://www.drupal.org/pift-ci-job/610235), I am getting a lot of PHP notices for undefined offset like

exception: [Notice] Line 46 of vendor/phenx/php-font-lib/src/FontLib/Table/Type/loca.php:
Undefined offset: 2144
....
exception: [Notice] Line 30 of vendor/phenx/php-font-lib/src/FontLib/Table/Type/hmtx.php:
Undefined offset: 5332

exception: [Notice] Line 31 of vendor/phenx/php-font-lib/src/FontLib/Table/Type/hmtx.php:
Undefined offset: 5333

I am not sure how to fix this, but checking the existence of the array element seems to me a right thing to do anyway

@PhenX PhenX merged commit e7df150 into dompdf:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants