Improve project quality and upgrade to .NET 9#5
Merged
discostu105 merged 2 commits intomasterfrom Mar 21, 2026
Merged
Conversation
- All 11 projects: net8.0 → net9.0 - Microsoft.* packages: 8.0.0 → 9.0.0 - AspNet.Security.OAuth.Discord: 6.0.10 → 9.0.0 - Serilog.AspNetCore: 8.0.0 → 9.0.0 - BenchmarkDotNet: 0.13.7 → 0.14.0 - xunit: 2.4.2 → 2.9.3, coverlet: 3.1.2 → 6.0.2 - Microsoft.NET.Test.Sdk: 17.8.0 → 17.12.0 - CI workflow: 8.0.x → 9.0.x https://claude.ai/code/session_01PeKjLeL9dZx8eR2hVsqCzA
The global.json pinned SDK version 8.0.418 with latestMinor roll-forward, which prevented the .NET 9 SDK installed in CI from being used. https://claude.ai/code/session_01PeKjLeL9dZx8eR2hVsqCzA
discostu105
added a commit
that referenced
this pull request
Mar 30, 2026
- Convert GameLobbyViewModels to record types (Architect blocking #1) - Add GameDefType and EndTime fields to GameSummaryViewModel and GameInfo (Architect required #5) - Fix AddPlayer() race condition: move PlayerCount update inside lock, return bool for duplicate-join detection (Architect blocking #2 and #3 / QA blocking #2) - Fix duplicate-join: return Conflict(409) if player already joined (Architect blocking #2) - Add [AllowAnonymous] to GetAll() — game list is a public endpoint per BGE-131 plan (Architect required #4) - Update controller to use record constructor syntax and handle AddPlayer bool return Build: 0 errors | Tests: 117/117 passed Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.editorconfig, removed unusedazure-pipelines.yml, fixed thread-safety issues withlockstatements in repository classes, removed unused imports, improvedProgram.csconfigurationnet8.0tonet9.0, bumped all Microsoft.* packages to 9.0.0, updated third-party packages (xunit, BenchmarkDotNet, Serilog, coverlet, etc.)Test plan
dotnet testlocally to confirm all tests passhttps://claude.ai/code/session_01PeKjLeL9dZx8eR2hVsqCzA