Fix PR #47 blocking issues for Game Lobby UI (BGE-145)

- Convert GameLobbyViewModels to record types (Architect blocking #1)
- Add GameDefType and EndTime fields to GameSummaryViewModel and GameInfo (Architect required #5)
- Fix AddPlayer() race condition: move PlayerCount update inside lock, return bool for duplicate-join detection (Architect blocking #2 and #3 / QA blocking #2)
- Fix duplicate-join: return Conflict(409) if player already joined (Architect blocking #2)
- Add [AllowAnonymous] to GetAll() — game list is a public endpoint per BGE-131 plan (Architect required #4)
- Update controller to use record constructor syntax and handle AddPlayer bool return

Build: 0 errors | Tests: 117/117 passed

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Author: discostu105

src/BrowserGameEngine.FrontendServer/Controllers/GamesController.cs

@@ -3,7 +3,6 @@
 using BrowserGameEngine.StatefulGameServer;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
-using System;
 using System.Linq;
 
 namespace BrowserGameEngine.FrontendServer.Controllers {
@@ -23,17 +22,20 @@ GameRepository gameRepository
 		}
 
 		[HttpGet]
+		[AllowAnonymous]
 		public ActionResult<GameListViewModel> GetAll() {
-			var games = gameRepository.GetAll().Select(g => new GameSummaryViewModel {
-				GameId = g.GameId,
-				Name = g.Name,
-				Status = g.Status.ToString().ToLowerInvariant(),
-				PlayerCount = g.PlayerCount,
-				MaxPlayers = g.MaxPlayers,
-				StartTime = g.StartTime,
-				CanJoin = g.Status == GameStatus.Upcoming
-			}).ToList();
-			return Ok(new GameListViewModel { Games = games });
+			var games = gameRepository.GetAll().Select(g => new GameSummaryViewModel(
+				g.GameId,
+				g.Name,
+				g.GameDefType,
+				g.Status.ToString().ToLowerInvariant(),
+				g.PlayerCount,
+				g.MaxPlayers,
+				g.StartTime,
+				g.EndTime,
+				g.Status == GameStatus.Upcoming
+			)).ToList();
+			return Ok(new GameListViewModel(games));
 		}
 
 		[HttpPost("{gameId}/join")]
@@ -42,7 +44,9 @@ public ActionResult Join(string gameId) {
 			var game = gameRepository.Get(gameId);
 			if (game == null) return NotFound();
 			if (game.Status != GameStatus.Upcoming) return BadRequest("This game is not open for joining.");
-			gameRepository.AddPlayer(gameId, currentUserContext.PlayerId!.Id);
+			if (!gameRepository.AddPlayer(gameId, currentUserContext.PlayerId!.Id)) {
+				return Conflict("You have already joined this game.");
+			}
 			return Ok();
 		}
 	}

src/BrowserGameEngine.Shared/GameLobbyViewModels.cs

@@ -2,21 +2,19 @@
 using System.Collections.Generic;
 
 namespace BrowserGameEngine.Shared {
-	public class GameListViewModel {
-		public List<GameSummaryViewModel> Games { get; set; } = new();
-	}
+	public record GameSummaryViewModel(
+		string GameId,
+		string Name,
+		string GameDefType,
+		string Status,
+		int PlayerCount,
+		int MaxPlayers,
+		DateTime? StartTime,
+		DateTime? EndTime,
+		bool CanJoin
+	);
 
-	public class GameSummaryViewModel {
-		public string GameId { get; set; } = "";
-		public string Name { get; set; } = "";
-		public string Status { get; set; } = "";
-		public int PlayerCount { get; set; }
-		public int MaxPlayers { get; set; }
-		public DateTime? StartTime { get; set; }
-		public bool CanJoin { get; set; }
-	}
+	public record GameListViewModel(List<GameSummaryViewModel> Games);
 
-	public class JoinGameRequest {
-		public string GameId { get; set; } = "";
-	}
+	public record JoinGameRequest(string GameId);
 }

src/BrowserGameEngine.StatefulGameServer/Repositories/Game/GameInfo.cs

@@ -10,9 +10,11 @@ public enum GameStatus {
 	public class GameInfo {
 		public string GameId { get; set; } = "";
 		public string Name { get; set; } = "";
+		public string GameDefType { get; set; } = "sco";
 		public GameStatus Status { get; set; }
 		public int PlayerCount { get; set; }
 		public int MaxPlayers { get; set; }
 		public DateTime? StartTime { get; set; }
+		public DateTime? EndTime { get; set; }
 	}
 }

src/BrowserGameEngine.StatefulGameServer/Repositories/Game/GameRepository.cs

@@ -27,14 +27,17 @@ public bool IsPlayerInGame(string gameId, string playerId) {
 			return playersByGame.TryGetValue(gameId, out var players) && players.Contains(playerId);
 		}
 
-		public void AddPlayer(string gameId, string playerId) {
+		public bool AddPlayer(string gameId, string playerId) {
 			var players = playersByGame.GetOrAdd(gameId, _ => new HashSet<string>());
 			lock (players) {
-				players.Add(playerId);
-			}
-			if (games.TryGetValue(gameId, out var game)) {
-				game.PlayerCount = playersByGame.TryGetValue(gameId, out var p) ? p.Count : 0;
+				if (!players.Add(playerId)) {
+					return false;
+				}
+				if (games.TryGetValue(gameId, out var game)) {
+					game.PlayerCount = players.Count;
+				}
 			}
+			return true;
 		}
 
 		private void SeedDefaultGames() {
@@ -45,23 +48,26 @@ private void SeedDefaultGames() {
 				Status = GameStatus.Upcoming,
 				PlayerCount = 0,
 				MaxPlayers = 50,
-				StartTime = now.AddDays(2)
+				StartTime = now.AddDays(2),
+				EndTime = now.AddDays(16)
 			};
 			var active1 = new GameInfo {
 				GameId = "game-beta",
 				Name = "Beta Season",
 				Status = GameStatus.Active,
 				PlayerCount = 12,
 				MaxPlayers = 50,
-				StartTime = now.AddDays(-5)
+				StartTime = now.AddDays(-5),
+				EndTime = now.AddDays(9)
 			};
 			var finished1 = new GameInfo {
 				GameId = "game-s1",
 				Name = "Season 1",
 				Status = GameStatus.Finished,
 				PlayerCount = 38,
 				MaxPlayers = 50,
-				StartTime = now.AddDays(-30)
+				StartTime = now.AddDays(-30),
+				EndTime = now.AddDays(-16)
 			};
 			games[upcoming1.GameId] = upcoming1;
 			games[active1.GameId] = active1;