Fix SMT object tracking test #7015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was removed due to incompatibility with new INVARIANT in the constuctor of member_exprt, which now checks that member is being accessed on a struct/union typed operand. This commit adds the test back as a precursor to making it compatible with the new INVARIANT.
To fix this test, more appropriate type information needs to be added. This will result in differing object_base types for each check. This will be simpler to write in sections rather than `GENERATE` rows.
So that it is compatible with the new INVARIANT in the constructor of `member_exprt`.
To make it easier to debug.
To make the intention of each test section clearer.
peterschrammel
approved these changes
Jul 19, 2022
NlightNFotis
approved these changes
Jul 19, 2022
Codecov Report
@@ Coverage Diff @@
## develop #7015 +/- ##
========================================
Coverage 77.86% 77.87%
========================================
Files 1569 1569
Lines 180821 180903 +82
========================================
+ Hits 140801 140882 +81
- Misses 40020 40021 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A unit test was removed in #6949 . This PR adds the test back and fixes it.