member_exprt now checks type of compound operand #6949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
reviewed
Jun 20, 2022
kroening
force-pushed
the
member_exprt_check
branch
4 times, most recently
from
5009854 to
716545f
Compare
kroening
requested review from
martin-cs,
peterschrammel and
chris-ryder
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #6949 +/- ##
===========================================
+ Coverage 77.85% 77.86% +0.01%
===========================================
Files 1569 1569
Lines 180670 180821 +151
===========================================
+ Hits 140662 140801 +139
- Misses 40008 40020 +12
Continue to review full report at Codecov.
|
tautschnig
force-pushed
the
member_exprt_check
branch
from
716545f to
80e5b1a
Compare
tautschnig
approved these changes
Jun 20, 2022
tautschnig
force-pushed
the
member_exprt_check
branch
from
80e5b1a to
136ae1c
Compare
kroening
force-pushed
the
member_exprt_check
branch
from
136ae1c to
3c91a04
Compare
kroening
force-pushed
the
member_exprt_check
branch
from
3c91a04 to
352832a
Compare
kroening
force-pushed
the
member_exprt_check
branch
from
352832a to
11089b4
Compare
tautschnig
reviewed
Jul 14, 2022
| @@ -55,7 +59,7 @@ TEST_CASE("Tracking object base expressions", "[core][smt2_incremental]") | |||
| address_of_exprt{index_exprt{foo, index}, pointer_type}, bar_address}, | |||
| notequal_exprt{ | |||
| address_of_exprt{ | |||
| member_exprt{foo, "baz", unsignedbv_typet{8}}, pointer_type}, | |||
| member_exprt::unchecked(foo, "baz", unsignedbv_typet{8}), pointer_type}, | |||
There was a problem hiding this comment.
This will still need fixing?
kroening
force-pushed
the
member_exprt_check
branch
from
11089b4 to
88d3b5e
Compare
This commit adds a precondition to the constructors of member_exprt that enforces that the compound operand has one of the compound types.
kroening
force-pushed
the
member_exprt_check
branch
from
88d3b5e to
55fc192
Compare
peterschrammel
approved these changes
Jul 18, 2022
| @@ -12,41 +12,12 @@ | |||
| #include <string> | |||
| #include <utility> | |||
|
|
|||
| TEST_CASE("find_object_base_expression", "[core][smt2_incremental]") | |||
There was a problem hiding this comment.
@thomasspriggs is going to re-add a fixed version of this test after this PR has been merged.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a precondition to the constructors of
member_exprtthatenforces that the compound operand has one of the compound types.
A legacy constructor is offered to ease the transition.