Skip to content

Fix(dre): Handle unexpected zero node reward types count #1584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DFINITYManu merged 1 commit into from
Jun 11, 2025
Merged

Fix(dre): Handle unexpected zero node reward types count #1584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rs/cli/src/commands/registry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,11 @@ fn fetch_max_rewardable_count(record: &Operator, nodes_in_registry: u64) -> BTre
if nodes_in_registry == 0 {
return BTreeMap::new();
}
panic!("This should never happen");
warn!(
"Node operator {} has {} nodes in registry with {} node allowance total, but {} reward types! The rewardable nodes by reward type for this operator are: {:?}",
record.principal, nodes_in_registry, node_allowance_total, nodes_rewards_types_count, record.rewardable_nodes
);
BTreeMap::new()
}

async fn get_node_operators(local_registry: &Arc<dyn LazyRegistry>, network: &Network) -> anyhow::Result<IndexMap<PrincipalId, NodeOperator>> {
Expand Down
Loading