Fix(dre): Handle unexpected zero node reward types count #1584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved panic by logging warning and returning an empty map when the node operator has nodes in the registry and rewardable nodes, but somehow no node reward types. - Replaced `panic!` with `warn!` to log the issue instead of terminating execution. - Provided detailed information in the log, including the principal, total nodes allowed, and reward types count.
NikolaMilosa
approved these changes
Jun 11, 2025
Contributor
NikolaMilosa
left a comment
NikolaMilosa
left a comment
There was a problem hiding this comment.
I'll approve for now but this should be reviewed by @pietrodimarco-dfinity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved panic by logging warning and returning an empty map when the node operator has nodes in the registry and rewardable nodes, but somehow no node reward types.
panic!withwarn!to log the issue instead of terminating execution.Addresses (but does not necessarily fix) https://dfinity.atlassian.net/browse/DRE-466 .