feat: IC-1680: Add NPR V1 lib - Rewards Calculation #1388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Cargo.Bazel.lock
…b' into pmarco/add-rewards-multiplier-lib
…-rewards-xdr # Conflicts: # Cargo.Bazel.lock # Cargo.lock # rs/node-provider-rewards/Cargo.toml # rs/node-provider-rewards/src/lib.rs # rs/node-provider-rewards/src/logs.rs # rs/node-provider-rewards/src/performance_calculator.rs # rs/node-provider-rewards/src/performance_calculator/tests.rs
…b-rewards-xdr' into pmarco/add-rewards-multiplier-lib-rewards-xdr
…for better error handling
DFINITYManu
reviewed
Mar 19, 2025
Contributor
DFINITYManu
left a comment
DFINITYManu
left a comment
There was a problem hiding this comment.
A small refactor is taking place, I will review again after the refactor. Code is looking quite good!
…rewards calculation logic
…ucture and clarity
… contexts for clarity and consistency
# Conflicts: # Cargo.Bazel.lock
…b-rewards-xdr' into pmarco/add-rewards-multiplier-lib-rewards-xdr
DFINITYManu
reviewed
Mar 20, 2025
DFINITYManu
reviewed
Mar 20, 2025
…and improve node grouping logic
…b-rewards-xdr' into pmarco/add-rewards-multiplier-lib-rewards-xdr
DFINITYManu
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node Provider Rewards V1 Library
Second phase of NPR_V1 implementation here the first phase.
In this phase the computed
PerformanceMultipliersare applied to the monthly XDR Rewards each node receives for participating in the IC network.RewardsCalculatorwhich computes rewards per Node Provider given nodesPerformanceMultipliersandNodeRewardsTableExecutionContextfunctionality used now as holder for final/intermediate resultsComputationTableNext Steps (TODO)
RewardsCalculatorBaseRewardsfor eachNodeCategoryIntermediateResultsin stable memory