-
Notifications
You must be signed in to change notification settings - Fork 8
feat: IC-1680: Add NPR V1 lib - Performance Multiplier Calculator #1300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pietrodimarco-dfinity
merged 32 commits into
main
from
pmarco/add-rewards-multiplier-lib
Mar 4, 2025
Merged
feat: IC-1680: Add NPR V1 lib - Performance Multiplier Calculator #1300
pietrodimarco-dfinity
merged 32 commits into
main
from
pmarco/add-rewards-multiplier-lib
Mar 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b' into pmarco/add-rewards-multiplier-lib
DFINITYManu
reviewed
Mar 3, 2025
DFINITYManu
reviewed
Mar 3, 2025
…ance calculations
# Conflicts: # Cargo.Bazel.lock
DFINITYManu
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node Provider Rewards V1 Library
This library computes performance-based rewards (in XDR) for node providers over a given reward period. Rewards are adjusted based on each node's performance using trustworthy node metrics. The implementation follows the accepted proposal 135054.
This PR implement the first step of the reward computation process:
PerformanceMultiplierscomputation for each node based on its failure rate, derived from the number of blocks it failed to propose vs. successfully proposed.PerformanceMultiplierscomputation and library inputs.Next Steps (TODO)
The next phase will apply the computed PerformanceMultipliers to the monthly XDR incentives each node receives for participating in the IC network.