Log all non-default fields when updating config #924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AObuchow
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
Looks good to me.
I resolved the conflicts locally (let me know if you want me to push the changes, for convenience).
I set the config's progressTimeout to 15m and set cleanupOnStop to true, and the following was (correctly) logged:
{
"level":"info",
"ts":1663032819.8720434,
"logger":"operator-configuration",
"msg":"Updated config to [routing.clusterHostSuffix=192.168.49.2.nip.io,workspace.progressTimeout=15m,workspace.cleanupOnStop=true]"
}
ibuziuk
approved these changes
Sep 13, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Log the setting for workspace.cleanupOnStop and workspace.progressTimeout when they are set to non-default values. For now, we don't log .workspace.podSecurityContext as it's not simple to detect non-default values there. Signed-off-by: Angel Misevski <[email protected]>
amisevsk
force-pushed
the
log-full-config
branch
from
184b000 to
784c15e
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Log all non-default fields in config when updating config to avoid missing info. Previously, settings like cleanupOnStop and progressTimeout were ignored in the config log, which is confusing.
For now, we still don't log differences in
workspace.podSecurityContextas it's not as simple to diff the structs.This PR should probably not be merged before #918 to avoid an annoying merge conflict.
What issues does this PR fix or reference?
N/A, minor fixup
Is it tested? How?
Start DWO and set custom values for
.config.workspace.cleanupOnStopand.config.workspace.progressTimeoutPR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che