Log all non-default fields when updating config

Log the setting for workspace.cleanupOnStop and
workspace.progressTimeout when they are set to non-default values.

For now, we don't log .workspace.podSecurityContext as it's not simple
to detect non-default values there.

Signed-off-by: Angel Misevski <[email protected]>

Author: amisevsk

pkg/config/sync.go

@@ -275,6 +275,7 @@ func logCurrentConfig() {
 		}
 	}
 	if Workspace != nil {
+		// Don't include PodSecurityContext for now as it's less easy to compare
 		if Workspace.ImagePullPolicy != defaultConfig.Workspace.ImagePullPolicy {
 			config = append(config, fmt.Sprintf("workspace.imagePullPolicy=%s", Workspace.ImagePullPolicy))
 		}
@@ -287,10 +288,16 @@ func logCurrentConfig() {
 		if Workspace.IdleTimeout != defaultConfig.Workspace.IdleTimeout {
 			config = append(config, fmt.Sprintf("workspace.idleTimeout=%s", Workspace.IdleTimeout))
 		}
+		if Workspace.ProgressTimeout != "" && Workspace.ProgressTimeout != defaultConfig.Workspace.ProgressTimeout {
+			config = append(config, fmt.Sprintf("workspace.progressTimeout=%s", Workspace.ProgressTimeout))
+		}
 		if Workspace.IgnoredUnrecoverableEvents != nil {
 			config = append(config, fmt.Sprintf("workspace.ignoredUnrecoverableEvents=%s",
 				strings.Join(Workspace.IgnoredUnrecoverableEvents, ";")))
 		}
+		if Workspace.CleanupOnStop != nil && *Workspace.CleanupOnStop != *defaultConfig.Workspace.CleanupOnStop {
+			config = append(config, fmt.Sprintf("workspace.cleanupOnStop=%t", *Workspace.CleanupOnStop))
+		}
 		if Workspace.DefaultStorageSize != nil {
 			if Workspace.DefaultStorageSize.Common != nil {
 				config = append(config, fmt.Sprintf("workspace.defaultStorageSize.common=%s", Workspace.DefaultStorageSize.Common.String()))