Update Devfile API Go module to add version to module path #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the Go module path of the Devfile API to add the major version to its path, allowing v2 (and higher) versions of the module to be published. Signed-off-by: John Collier <[email protected]>
johnmcollier
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
sleshchenko
approved these changes
Dec 17, 2020
davidfestal
approved these changes
Dec 22, 2020
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, davidfestal, johnmcollier, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
amisevsk
added a commit
to amisevsk/devworkspace-operator
that referenced
this pull request
Jan 8, 2021
* Update Makefile to point at latest devfile/api commit and support v2 * Update to devfile/api commit f33d2987d137225cd1e8975f6fdfdd2663195a37 * Adapt code to support new module name (.../v2) (see: devfile/api#280) Signed-off-by: Angel Misevski <[email protected]>
amisevsk
added a commit
to amisevsk/devworkspace-operator
that referenced
this pull request
Feb 17, 2021
* Update Makefile to point at latest devfile/api commit and support v2 * Update to devfile/api commit f33d2987d137225cd1e8975f6fdfdd2663195a37 * Adapt code to support new module name (.../v2) (see: devfile/api#280) Signed-off-by: Angel Misevski <[email protected]>
amisevsk
added a commit
to devfile/devworkspace-operator
that referenced
this pull request
Feb 22, 2021
* Update Makefile to point at latest devfile/api commit and support v2 * Update to devfile/api commit f33d2987d137225cd1e8975f6fdfdd2663195a37 * Adapt code to support new module name (.../v2) (see: devfile/api#280) Signed-off-by: Angel Misevski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the Go module path of the Devfile API to add the major version to its path, allowing v2 (and higher) versions of the module to be published.
As discussed on yesterday's Devfile cabal, to be able to publish the Devfile API Go module with a version of v2 or higher (and to ensure the module's version matches the Devfile schema version), we decided to update the module path of the Devfile API module to include the major version (
v2in this case). Some discussion on why this is needed can be found here.Once this PR is merged, consumers of the Devfile API Go module will need to update the import paths of the module's packages (
github.com/devfile/api/pkg/...->github.com/devfile/api/v2/pkg/...) when they update the version of the API module that they pull in that has these changes.What issues does this PR fix or reference?
N/A, but related to #150 and #278 (I can open a dedicated issue if needed).
Is your PR tested? Consider putting some instruction how to test your changes
N/A
Docs PR
N/A
CC @amisevsk @davidfestal @elsony @kadel @l0rd