Define devfile versioning and release process #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
johnmcollier
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
Signed-off-by: John Collier <[email protected]>
amisevsk
reviewed
Dec 11, 2020
Co-authored-by: Angel Misevski <[email protected]>
Co-authored-by: Angel Misevski <[email protected]>
elsony
requested changes
Dec 11, 2020
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
Signed-off-by: John Collier <[email protected]>
johnmcollier
force-pushed
the
versioning
branch
from
ed83115 to
5ce6613
Compare
Co-authored-by: Angel Misevski <[email protected]>
Co-authored-by: Angel Misevski <[email protected]>
|
Thanks @amisevsk, I've commited your two recommendations |
elsony
requested changes
Dec 16, 2020
|
@elsony Thanks, updated to add the cosmetic changes |
sleshchenko
approved these changes
Dec 17, 2020
Signed-off-by: John Collier <[email protected]>
elsony
requested changes
Dec 17, 2020
Signed-off-by: John Collier <[email protected]>
|
@elsony I've updated the PR. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, elsony, johnmcollier, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds a proposal on how to handle versioning in the devfile spec, as well as outlining a process for releasing the devfile schema and Go modules.
What issues does this PR fix or reference?
#150
Is your PR tested? Consider putting some instruction how to test your changes
N/A
Docs PR
N/A