Move /health endpoint to /mcp/health

[keyurva]

• Pushed to staging and separately updated the nonprod apigee config in mixer to make it unprotected: https://staging.api.datacommons.org/mcp/health
• Will send out the mixer PR also, submit it and then update the prod apigee config

[gemini-code-assist]

Summary of Changes

Hello @keyurva, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on relocating the /health endpoint to /mcp/health for the datacommons-mcp service. This change ensures consistency across the application's routing and its Docker health check configuration. The update is part of a broader effort to align with external API gateway configurations, as indicated by the associated Apigee config updates.

Highlights

• Endpoint Relocation: The /health endpoint has been moved to /mcp/health across the application.
• Dockerfile Update: The Docker health check command has been updated to reflect the new /mcp/health endpoint.
• Application Route Change: The datacommons-mcp server's health check route definition has been modified to /mcp/health.
• Version Bump: The datacommons-mcp package version has been incremented from 1.1.4 to 1.1.5 in uv.lock.
• Deployment Documentation Adjustment: Minor updates were made to the deploy/README.md regarding manual git tag format and push origin.

Changelog

• Dockerfile
  • Updated the HEALTHCHECK CMD to target the new /mcp/health endpoint.
• deploy/README.md
  • Modified the manual git tag format from v1.1.3rc1 to v1.1.3.rc1.
  • Changed the git push command from git push origin to git push upstream.
• packages/datacommons-mcp/datacommons_mcp/server.py
  • Changed the health_check route decorator from /health to /mcp/health.
• uv.lock
  • Incremented the datacommons-mcp package version from 1.1.4 to 1.1.5.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/ci.yaml

Activity

• The changes have been pushed to staging, and the non-production Apigee configuration in mixer was updated to make the new endpoint unprotected.
• A mixer PR will be submitted, and the production Apigee configuration will be updated subsequently.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly moves the health check endpoint from /health to /mcp/health. The changes in the Python server code and the Dockerfile's HEALTHCHECK are accurate. I've added one comment to the deploy/README.md file suggesting an improvement to the documentation to prevent potential copy-paste errors and to fix an inconsistency.

[gemini-code-assist]

Using v1.1.3.rc1 is a good improvement for semantic versioning clarity. However, this example is hardcoded, which might lead to copy-paste errors. It would be more robust to use a placeholder like vX.Y.Z.rcN.

Additionally, there's an inconsistency in the document. The description on line 18 still mentions the old format v1.1.3rc1. It would be great to update that as well for consistency.

Suggested change

	git tag v1.1.3.rc1
	git push upstream v1.1.3.rc1
	git tag vX.Y.Z.rcN
	git push upstream vX.Y.Z.rcN

[clincoln8]

nit: i like vX.Y.Z.rcN but nw if you prefer the numbers

[keyurva]

Done.

[clincoln8]

nit: i like vX.Y.Z.rcN but nw if you prefer the numbers

[clincoln8]

just to double check -- is this intentional?

[keyurva]

Chatted offline but this is a result of running uv sync. I should've run it when I bumped the version in pyproject.toml. Something to keep in mind for future bumps.

[keyurva]

Thanks for the review!

[keyurva]

Done.

[keyurva]

Chatted offline but this is a result of running uv sync. I should've run it when I bumped the version in pyproject.toml. Something to keep in mind for future bumps.