Skip to content

Move /health endpoint to /mcp/health #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keyurva merged 4 commits into from
Feb 3, 2026
Merged

Move /health endpoint to /mcp/health #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4769ff6
Move /health endpoint to /mcp/health
keyurva Feb 2, 2026
82a0571
Update docker and ci configs
keyurva Feb 2, 2026
f4ed444
Address review comments
keyurva Feb 3, 2026
f861774
Merge remote-tracking branch 'origin/main' into health
keyurva Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ jobs:
# Poll the server to see if it's healthy, with a 15-second timeout
echo "Waiting for server to become healthy..."
for i in {1..15}; do
if curl -s --fail http://localhost:8088/health > /dev/null; then
if curl -s --fail http://localhost:8088/mcp/health > /dev/null; then
echo "Server started successfully!"
kill $SERVER_PID
exit 0
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ USER mcp
ENV PORT=8080

# Health check with Accept header and explicit PORT
HEALTHCHECK CMD curl --fail -H "Accept: application/json" http://localhost:${PORT}/health || exit 1
HEALTHCHECK CMD curl --fail -H "Accept: application/json" http://localhost:${PORT}/mcp/health || exit 1

# Use sh -c for variable expansion
CMD ["sh", "-c", "datacommons-mcp serve http --host 0.0.0.0 --port ${PORT}"]
4 changes: 2 additions & 2 deletions deploy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ python3 scripts/create_staging_tag.py
```
Or manually:
```bash
git tag v1.1.3rc1
git push origin v1.1.3rc1
git tag vX.Y.Z.rcN
git push upstream vX.Y.Z.rcN
```

## 3. Production Release
Expand Down
2 changes: 1 addition & 1 deletion packages/datacommons-mcp/datacommons_mcp/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
mcp = FastMCP("DC MCP Server", version=__version__)


@mcp.custom_route("/health", methods=["GET"])
@mcp.custom_route("/mcp/health", methods=["GET"])
async def health_check(request: Request) -> JSONResponse: # noqa: ARG001 request param required for decorator
return JSONResponse({"status": "OK", "version": __version__})

Expand Down
2 changes: 1 addition & 1 deletion uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.