-
-
Notifications
You must be signed in to change notification settings - Fork 735
Replace conda with mamba #4585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace conda with mamba #4585
Conversation
Shave 2 minutes off each workflow
@jrbourbeau my tests are being randomly killed. Is #4581 acting up? |
Hmm that is strange. I don't think it's the Interestingly all the CI runs are existing when they hit the same test |
@jrbourbeau looking more carefully, it's a deterministic failure on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into things @crusaderky. FWIW here's the test PR I opened up to test CI against main
#4586. Note that I didn't encounter the test_profile_nested_sizeof
issue in that PR
debug debug debug debug debug
It's ipython/ipython#12197 again. |
@jrbourbeau ready for review and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this @crusaderky!
From the output of mamba list
it looks like we're installing more packages from defaults
than conda-forge
than we do with our current setup in main
. Looking at the README for conda-incubator/setup-miniconda
it appears using mamba
requires us to explicitly include conda-forge
in the workflow step. Fortunately, when I tried this out in jrbourbeau@20ffce4, I was also able to remove the ipython
workaround (see this CI build)
@jrbourbeau I integrated your change |
@jakirkham switching to distributed/continuous_integration/environment-3.9.yaml Lines 2 to 5 in 8942856
Do you know if there's a reason to prefer the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crusaderky! Will merge after CI finishes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm it looks like we're not installing from conda-forge
by default again and are running into the ipython
issue
Weird. I tried removing the line that sets the channels in the workflow because I spotted that in the latest version it's getting packages from the pytorch channel... but apparently it's something else |
This reverts commit 9bf707a.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crusaderky! This is in
Sorry missed this 😞 At the time |
Both pytorch and torchvision are still being pulled from the pytorch channel after this PR anyway |
Shave 2 minutes off each workflow
Twin of dask/dask#7227