-
-
Notifications
You must be signed in to change notification settings - Fork 735
Install PyTorch on CI #4017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install PyTorch on CI #4017
Conversation
In order to run PyTorch tests on CI, make sure that it gets installed.
Any thoughts on this? |
Thanks for the PR @jakirkham! I'm +0.5 on adding |
We saw some issues where the PyTorch serializers were not being used. So wanted to make sure they are working and tests pass. Additionally we are interested in extending these to handle more efficiently GPU serialization. So it would help to have a sanity check to make sure we don't break what already works in the process. Would it be better if we only install PyTorch on one job as opposed to all of them? |
Should add I think part of the issue is PyTorch pulls in MKL, which is quite large and takes some time to install. |
Yeah, I think that would make the situation better. I'll plan to merge at the end of the day if there are no objections |
Thanks James! Moved to the Python 3.8 job. Though happy to move to a different job if there is a preference. |
8aa56f7
to
7cc05b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jakirkham, this is in
Thanks James! 😄 |
In order to run PyTorch tests on CI, make sure that it gets installed.