Skip to content

Install PyTorch on CI #4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2020
Merged

Install PyTorch on CI #4017

merged 2 commits into from
Aug 7, 2020

Conversation

jakirkham
Copy link
Member

In order to run PyTorch tests on CI, make sure that it gets installed.

In order to run PyTorch tests on CI, make sure that it gets installed.
@jakirkham
Copy link
Member Author

Any thoughts on this?

cc @mrocklin @jrbourbeau @quasiben

@jrbourbeau
Copy link
Member

Thanks for the PR @jakirkham! I'm +0.5 on adding pytorch to CI. It'd be great to run pytorch-related tests. However it looks like conda install pytorch adds a little over 2 minutes to our Travis builds. That's probably not prohibitive given that builds take ~40 minutes today, but small additions do add up over time. Do you know if there have been issues recently where having pytorch in CI would have helped?

@jakirkham
Copy link
Member Author

We saw some issues where the PyTorch serializers were not being used. So wanted to make sure they are working and tests pass. Additionally we are interested in extending these to handle more efficiently GPU serialization. So it would help to have a sanity check to make sure we don't break what already works in the process.

Would it be better if we only install PyTorch on one job as opposed to all of them?

@jakirkham
Copy link
Member Author

Should add I think part of the issue is PyTorch pulls in MKL, which is quite large and takes some time to install.

@jrbourbeau
Copy link
Member

Would it be better if we only install PyTorch on one job as opposed to all of them?

Yeah, I think that would make the situation better.

I'll plan to merge at the end of the day if there are no objections

@jakirkham
Copy link
Member Author

Thanks James! Moved to the Python 3.8 job. Though happy to move to a different job if there is a preference.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakirkham, this is in

@jrbourbeau jrbourbeau merged commit 004ea9c into dask:master Aug 7, 2020
@jakirkham jakirkham deleted the tst_pytorch_ci branch August 7, 2020 04:03
@jakirkham
Copy link
Member Author

Thanks James! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants