Skip to content

Optimize url encoding, use default port for debugger service #1402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Sep 6, 2021

  • Optimize encoding of the extension url by not awaiting on the result until needed.
    • This cuts the startup time of dwds.
  • Try binding debug service to a constant port if possible.
    • This will help with caching VM's API responses.

closes: #1400
helps: #1401

@google-cla google-cla bot added the cla: yes label Sep 6, 2021
@annagrin annagrin requested review from grouma and nshahan September 6, 2021 21:54
@annagrin annagrin requested a review from grouma September 7, 2021 19:13
@annagrin
Copy link
Contributor Author

annagrin commented Sep 7, 2021

I will wait with submitting this until we have metrics ready.

@annagrin annagrin force-pushed the annagrin/encode_url_optimization branch from e977050 to b7bafd2 Compare September 14, 2021 19:13
@annagrin
Copy link
Contributor Author

rebased onto latest master

@annagrin annagrin merged commit 256dce9 into dart-lang:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize url encoding of debug extension url
3 participants