Only consider extension types that start with JS as JS types #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExternalDartReference has been added to dart:js_interop but is not a JS type and doesn't belong in the type hierarchy for union calculation.
kevmoo
approved these changes
Apr 12, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Apr 15, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/ba77660..f339b09): f339b094 2024-04-12 Sam Rawlins Properly sort unnamed libraries (dart-lang/dartdoc#3746) ecosystem (https://github.com/dart-lang/ecosystem/compare/95fed18..9fabe46): 9fabe46 2024-04-15 Moritz Add check for API leaks to the Health workflow (dart-lang/ecosystem#251) web (https://github.com/dart-lang/web/compare/3d1b4cb..9d8c802): 9d8c802 2024-04-12 Srujan Gaddam Only consider extension types that start with JS as JS types (dart-lang/web#224) b53bd7f 2024-04-12 M. Hanif Shahy Update README.md (dart-lang/web#223) Change-Id: I1009a9acb7fbbf6f276139f1e1a4a5ae2b1e16f5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362822 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExternalDartReference has been added to dart:js_interop but is not a JS type and doesn't belong in the type hierarchy for union calculation. Fixes an assertion failure.