-
Notifications
You must be signed in to change notification settings - Fork 8
Add check for API leaks to the Health workflow #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR HealthBreaking changes ✔️Details
Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️Details
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️DetailsThe following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️Details
All source files should start with a license header. Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/ba77660..f339b09): f339b094 2024-04-12 Sam Rawlins Properly sort unnamed libraries (dart-lang/dartdoc#3746) ecosystem (https://github.com/dart-lang/ecosystem/compare/95fed18..9fabe46): 9fabe46 2024-04-15 Moritz Add check for API leaks to the Health workflow (dart-lang/ecosystem#251) web (https://github.com/dart-lang/web/compare/3d1b4cb..9d8c802): 9d8c802 2024-04-12 Srujan Gaddam Only consider extension types that start with JS as JS types (dart-lang/web#224) b53bd7f 2024-04-12 M. Hanif Shahy Update README.md (dart-lang/web#223) Change-Id: I1009a9acb7fbbf6f276139f1e1a4a5ae2b1e16f5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362822 Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]> Auto-Submit: Devon Carew <[email protected]>
Check for symbols which are not exported, but visible in the public API.
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.