Skip to content

Add check for API leaks to the Health workflow #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Add check for API leaks to the Health workflow #251

merged 10 commits into from
Apr 15, 2024

Conversation

mosuem
Copy link
Member

@mosuem mosuem commented Apr 12, 2024

Check for symbols which are not exported, but visible in the public API.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

github-actions bot commented Apr 12, 2024

PR Health

Breaking changes ✔️

Details
Package Change Current Version New Version Needed Version Looking good?
firehose Non-Breaking 0.8.0 0.9.0 0.8.1 ✔️

Changelog Entry ✔️

Details
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

Coverage ✔️

Details
File Coverage
pkgs/firehose/lib/firehose.dart 💚 35 %
pkgs/firehose/lib/src/health/health.dart 💚 94 %

This check for test coverage is informational (issues shown here will not fail the PR).

API leaks ✔️

Details

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols

License Headers ✔️

Details
// Copyright (c) 2024, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Package publish validation ✔️

Details
Package Version Status
package:firehose 0.9.0 ready to publish
package:dart_flutter_team_lints 2.1.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Apr 12, 2024
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:firehose 0.9.0 ready to publish firehose-v0.9.0
package:dart_flutter_team_lints 2.1.2-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@mosuem mosuem requested a review from devoncarew April 12, 2024 15:00
@mosuem mosuem merged commit 9fabe46 into main Apr 15, 2024
@mosuem mosuem deleted the addApiLeakCheck branch April 15, 2024 08:26
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 15, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/ba77660..f339b09):
  f339b094  2024-04-12  Sam Rawlins  Properly sort unnamed libraries (dart-lang/dartdoc#3746)

ecosystem (https://github.com/dart-lang/ecosystem/compare/95fed18..9fabe46):
  9fabe46  2024-04-15  Moritz  Add check for API leaks to the Health workflow (dart-lang/ecosystem#251)

web (https://github.com/dart-lang/web/compare/3d1b4cb..9d8c802):
  9d8c802  2024-04-12  Srujan Gaddam  Only consider extension types that start with JS as JS types (dart-lang/web#224)
  b53bd7f  2024-04-12  M. Hanif Shahy  Update README.md (dart-lang/web#223)

Change-Id: I1009a9acb7fbbf6f276139f1e1a4a5ae2b1e16f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362822
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
Auto-Submit: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:firehose skip-do-not-submit-check type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants