Skip to content

Fix typo. #4483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

Fix typo. #4483

merged 1 commit into from
Aug 7, 2025

Conversation

eugenefil
Copy link
Contributor

Fix typo: the superinvocation interface is M_S, not M_super (which is a class name).


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@munificent
Copy link
Member

@eernstg, thoughts?

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -6042,7 +6042,7 @@ \subsection{Mixin Declaration}
\Index{superinvocation interface} of the mixin declaration $M$.
\commentary{%
If the mixin declaration $M$ has only one declared superinterface, $T_1$,
then the superinvocation interface $M_{super}$ has exactly the same members
then the superinvocation interface $M_S$ has exactly the same members
Copy link
Member

@eernstg eernstg Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @eugenefil!

An interface is a set of member signatures. Every interface type (including class types) has a uniquely determined interface, which means that there is no doubt what "the interface $M_{super}$" means, namely, the interface of the class whose name is denoted by the symbol $M_{super}$. We usually say "the interface of" a given class, and the interface usually doesn't have its own designator (but here we have explicitly named it as $M_S$). So it doesn't really say anything wrong, but it abuses the terminology slightly. $M_S$ is better.

@eernstg
Copy link
Member

eernstg commented Aug 7, 2025

/gcbrun

@eernstg eernstg merged commit 9287a52 into dart-lang:main Aug 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants