enforce new selection for "remove" action

[saidelike]

Checklist

• I have added tests
• I have updated the docs and cheatsheet
• I have not broken the cheatsheet

From debugging the vscode cursorless extension, it seems the selection is automatically updated by vscode itself when dealing with the "remove" action while calling editBuilder.delete() (TextEditorEdit).

However it is not the case for neovim so it was using the old selection.

I fixed it so cursorless always enforce selection for that "remove" action. Tested on neovim and vscode.

[pokey]

Good stuff. @AndreasArvidsson and I had discussed at one point having a version of performEditsAndUpdateSelections that does this automatically, as I believe it would be useful in other contexts, ie if you copy-pasted this code from somewhere else they could both use that abstraction

[pokey]

Looks good with a couple more minor tweaks

Btw what would happen if you just moved this work into the performEdits function? Then we could remove it from the place you stole this code from. @AndreasArvidsson do you see any reason not to always update the cursor position the way we want? I guess for eg "change" / "clear" it's a waste of work. But my leaning would be an option to disable the behaviour when you know you're going to move the cursor anyway, but to do it by default if not

[saidelike]

Looks good with a couple more minor tweaks

Btw what would happen if you just moved this work into the performEdits function? Then we could remove it from the place you stole this code from. @AndreasArvidsson do you see any reason not to always update the cursor position the way we want? I guess for eg "change" / "clear" it's a waste of work. But my leaning would be an option to disable the behaviour when you know you're going to move the cursor anyway, but to do it by default if not

I propose to look into that in a future PR.

[AndreasArvidsson]

Looks good with a couple more minor tweaks

Btw what would happen if you just moved this work into the performEdits function? Then we could remove it from the place you stole this code from. @AndreasArvidsson do you see any reason not to always update the cursor position the way we want? I guess for eg "change" / "clear" it's a waste of work. But my leaning would be an option to disable the behaviour when you know you're going to move the cursor anyway, but to do it by default if not

The only reason I can think is if you make multiple edits and just want to update the selection at the end. I have no idea if we do that in any place and if we find that we need that behavior we could always add a parameter. Updating selection by default sounds reasonable.