Skip to content

Fix "puff" and "float" at end of file #742

Closed
@pokey

Description

@pokey

The "puff" and "float" actions don't work if you are at the end of a file that doesn't have a trailing newline. In order to fix this both should actually be inserted at the exact cursor position and we need to have isReplace on one of them. However this doesn't currently work due to a limitation in our range updater code. See #729 (comment) for more info.

We have recorded tests that capture the incorrect behaviour. The following tests should break, both in terms of cursor position and highlights, when this issue is fixed:

src/test/suite/fixtures/recorded/actions/insertEmptyLines/floatThis.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/floatThis2.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/floatThis3.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/floatThis4.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/floatThis5.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/floatThis6.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/floatThis7.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/puffThis.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/puffThis2.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/puffThis3.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/puffThis4.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/puffThis5.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/puffThis6.yml
src/test/suite/fixtures/recorded/actions/insertEmptyLines/puffThis7.yml

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions