Check serving addresses in provider service's endpointslice#50
Merged
ulucinar merged 1 commit intocrossplane:mainfrom Oct 7, 2025
Merged
Check serving addresses in provider service's endpointslice#50ulucinar merged 1 commit intocrossplane:mainfrom
ulucinar merged 1 commit intocrossplane:mainfrom
Conversation
2 tasks
ulucinar
force-pushed
the
check-ready-ips
branch
from
586c795 to
04a31c8
Compare
ulucinar
changed the title
- Use endpointslices instead of the endpoints as endpoints are deprecated from 1.33+. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
check-ready-ips
branch
from
04a31c8 to
99f610b
Compare
This was referenced Nov 25, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related PR: crossplane-contrib/provider-upjet-azure#1074
We now start checking for non-terminating serving addresses in the provider webhook's service endpointslice. Endpoints API is officially deprecated as of Kubernetes 1.33. We rely on the
servingcondition to check the provider service's endpointslice. And it should also be in non-terminating state too.With the readiness probes being introduced for the (official) providers starting with crossplane-contrib/provider-upjet-azure#1074, we need to make sure that at least one pod is ready to handle (API conversion) requests for uptest.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually tested the script. When the endpoint is ready, it exists with 0 after logging something like the following:
provider-family-azure-w5zk5 - Serving addresses [10.244.0.29] found in endpointsliceIf there are no ready provider pods, then it exists with a non-zero code after logging something like the following: