Add webhook server readyz checker#1880
Merged
ulucinar merged 3 commits intocrossplane-contrib:mainfrom Oct 16, 2025
Merged
Conversation
2 tasks
Collaborator
Author
|
/test-examples="examples/eks/cluster/v1beta1/cluster.yaml" |
6 similar comments
Collaborator
Author
|
/test-examples="examples/eks/cluster/v1beta1/cluster.yaml" |
Collaborator
Author
|
/test-examples="examples/eks/cluster/v1beta1/cluster.yaml" |
Collaborator
Author
|
/test-examples="examples/eks/cluster/v1beta1/cluster.yaml" |
Collaborator
Author
|
/test-examples="examples/eks/cluster/v1beta1/cluster.yaml" |
Collaborator
Author
|
/test-examples="examples/eks/cluster/v1beta1/cluster.yaml" |
Collaborator
Author
|
/test-examples="examples/eks/cluster/v1beta1/cluster.yaml" |
3 tasks
- Add command-line option "--health-probe-bind-addr" to configure the bind address for provider's health probe server. - Make use of the provider readiness probes in uptest by patching DeploymentRuntimeConfigs in local-deploy make target. - Bump upjet to commit 0b7f640373c8. - Switch from monolith package to config package in local-deploy make target. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
e6dcddf to
e0e6ace
Compare
Collaborator
Author
|
/test-examples="examples/eks/cluster/v1beta1/cluster.yaml" |
sergenyalcin
approved these changes
Oct 16, 2025
Collaborator
sergenyalcin
left a comment
There was a problem hiding this comment.
Thanks @ulucinar LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related PRs: crossplane/uptest#49, crossplane/uptest#50, crossplane-contrib/provider-upjet-azure#1074
This PR adds a controller-manager Webhook server readiness checker so that the provider's conversion webhook will not be marked as ready before the webhook server is actually started. There's been community requests for a readiness check implementation for a while as the API clients (when implicitly calling the conversion webhooks) had no way of knowing when the conversion webhook server has successfully started. This also affects the robustness of
uptest, which is also a client of the conversion webhook.This PR also introduces a new provider command-line option named
--health-probe-bind-addrso that the controller-manager health probe server's bind address can be customized. The default bind address is:8081.In order to utilize the new readiness probe, one can specify a
DeploymentRuntimeConfigwhich enables the readiness probe as follows:and install the Crossplane provider referring to this
DeploymentRuntimeConfig.This PR also switches from the monolithic provider to the config provider (
provider-family-aws) in thelocal-deployas we cannot run the monolith provider by installing all the CRDs. We will attempt to switch back to the monolith for better coverage when we start using Crossplane v2 and MR activations. Thelocal-deployjob is currently broken although it does not report errors when run in the pipeline jobs due to the missing readiness probes in the main HEAD.This PR also bumps the
kindversion tov0.30.0and migrates anENVcommand in the family Dockerfile to its new syntax.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Manually tested using
make generateandmake local-deploy.