conditionally select GHA runners - #1881
Merged
Merged
Conversation
This was referenced Oct 15, 2025
This was referenced Nov 11, 2025
Signed-off-by: Jason Tang <jason@upbound.io>
turkenf
force-pushed
the
gha-runner-fallback
branch
from
December 4, 2025 11:04
f7f8ee6 to
36352e7
Compare
turkenf
marked this pull request as ready for review
December 4, 2025 11:07
turkenf
requested review from
erhancagirici,
sergenyalcin,
turkenf and
ulucinar
as code owners
December 4, 2025 11:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Follow-up to #1838 to conditionally select the runner, since not all repository owners will have access to the CNCF Oracle runners if they fork this repository. Proposed an "equivalent" GitHub-hosted runner by spec for wider coverage on the fallback option.
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
ensure the "ternary" expression works on a fork. the trigger from this PR should also show the Oracle runner being selected.