fix(acl): Improve error handling - #211
Merged
fernandezcuesta merged 1 commit intoAug 6, 2026
Merged
Conversation
avoidik
force-pushed
the
improve-acl-error-handler
branch
from
July 15, 2026 13:05
061a8d3 to
957ac18
Compare
fernandezcuesta
changed the title
fernandezcuesta
requested changes
Jul 16, 2026
fernandezcuesta
left a comment
fernandezcuesta
left a comment
Collaborator
There was a problem hiding this comment.
Hi @avoidik, thanks for your contribution!
Some minor changes
avoidik
force-pushed
the
improve-acl-error-handler
branch
2 times, most recently
from
July 17, 2026 13:05
6c229ae to
66610e1
Compare
fernandezcuesta
requested changes
Jul 20, 2026
fernandezcuesta
left a comment
fernandezcuesta
left a comment
Collaborator
There was a problem hiding this comment.
Use testify in new tests
avoidik
force-pushed
the
improve-acl-error-handler
branch
2 times, most recently
from
July 27, 2026 19:08
a23671b to
ebef191
Compare
Contributor
Author
|
@fernandezcuesta If I understand the problem correctly: we updated a property on a topic, but the strimzi operator reverted it to the value defined in the initial CR spec, and then we checked for the value that is no longer there |
avoidik
force-pushed
the
improve-acl-error-handler
branch
from
July 29, 2026 20:53
7507bb0 to
def0d19
Compare
fernandezcuesta
approved these changes
Aug 5, 2026
Signed-off-by: Viacheslav Vasilyev <avoidik@gmail.com>
avoidik
force-pushed
the
improve-acl-error-handler
branch
from
August 5, 2026 13:00
d7b72ed to
7417623
Compare
Contributor
Author
|
Although all checks have passed and the PR is approved, I cannot merge this PR |
Collaborator
|
Thanks @avoidik for the contribution! Merging it! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes # #210
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested