fix(acl): Improve error handling -- apply suggestions

Signed-off-by: Viacheslav Vasilyev <avoidik@gmail.com>

Author: avoidik

internal/clients/kafka/acl/acl_test.go

@@ -8,6 +8,8 @@ import (
 	"time"
 
 	"github.com/google/go-cmp/cmp"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 	"github.com/twmb/franz-go/pkg/kadm"
 	"github.com/twmb/franz-go/pkg/kerr"
 	"k8s.io/apimachinery/pkg/util/json"
@@ -504,76 +506,64 @@ func TestList(t *testing.T) {
 // --- Unit tests for broker-level error propagation (no real Kafka needed) ---
 
 func TestCreateBrokerError(t *testing.T) {
+	t.Parallel()
 	cl := &fakeACLAdmin{
 		createResults: kadm.CreateACLsResults{
 			{Principal: "User:alice", Err: kerr.ClusterAuthorizationFailed},
 		},
 	}
 	err := Create(context.Background(), cl, &baseACL)
-	if err == nil {
-		t.Fatal("Create() expected error for broker-level Err, got nil")
-	}
+	require.Error(t, err)
 }
 
 func TestCreateEmptyResponse(t *testing.T) {
+	t.Parallel()
 	cl := &fakeACLAdmin{createResults: kadm.CreateACLsResults{}}
 	err := Create(context.Background(), cl, &baseACL)
-	if err == nil {
-		t.Fatal("Create() expected error for empty response, got nil")
-	}
+	require.Error(t, err)
 }
 
 func TestListBrokerError(t *testing.T) {
+	t.Parallel()
 	cl := &fakeACLAdmin{
 		describeResults: kadm.DescribeACLsResults{
 			{Err: kerr.ClusterAuthorizationFailed},
 		},
 	}
 	got, err := List(context.Background(), cl, &baseACL)
-	if err == nil {
-		t.Fatal("List() expected error for broker-level Err, got nil")
-	}
-	if got != nil {
-		t.Errorf("List() expected nil result on error, got %v", got)
-	}
+	require.Error(t, err)
+	assert.Nil(t, got)
 }
 
 func TestListNotFound(t *testing.T) {
+	t.Parallel()
 	cl := &fakeACLAdmin{
 		describeResults: kadm.DescribeACLsResults{
 			{Described: kadm.DescribedACLs{}},
 		},
 	}
 	got, err := List(context.Background(), cl, &baseACL)
-	if err != nil {
-		t.Fatalf("List() unexpected error: %v", err)
-	}
-	if got != nil {
-		t.Errorf("List() expected nil for no matching ACL, got %v", got)
-	}
+	require.NoError(t, err)
+	assert.Nil(t, got)
 }
 
 func TestListEmptyResponse(t *testing.T) {
+	t.Parallel()
 	cl := &fakeACLAdmin{describeResults: kadm.DescribeACLsResults{}}
 	got, err := List(context.Background(), cl, &baseACL)
-	if err != nil {
-		t.Fatalf("List() unexpected error: %v", err)
-	}
-	if got != nil {
-		t.Errorf("List() expected nil for empty response, got %v", got)
-	}
+	require.NoError(t, err)
+	assert.Nil(t, got)
 }
 
 func TestDeleteBrokerError(t *testing.T) {
+	t.Parallel()
 	cl := &fakeACLAdmin{
 		deleteResults: kadm.DeleteACLsResults{
 			{Err: kerr.ClusterAuthorizationFailed},
 		},
 	}
 	err := Delete(context.Background(), cl, &baseACL)
-	if err == nil {
-		t.Fatal("Delete() expected error for broker-level Err, got nil")
-	}
+	require.Error(t, err)
 }
 
 // TestListAtProviderNotFound verifies that List returns nil when the ACL does not exist.