Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

VM support - #270

Open
vaspahomov wants to merge 3 commits into
crossplane-contrib:masterfrom
vaspahomov:feature/vm-support
Open

VM support#270
vaspahomov wants to merge 3 commits into
crossplane-contrib:masterfrom
vaspahomov:feature/vm-support

Conversation

@vaspahomov

Copy link
Copy Markdown

Description of your changes

Add VM support
Fixes #78

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Same like in other resources like Subnet and VisrtualNetwork. And also manually tested

Signed-off-by: vaspahomov <vaspahomov@yandex-team.ru>
Signed-off-by: vaspahomov <vas2142553@gmail.com>
@vaspahomov
vaspahomov force-pushed the feature/vm-support branch 2 times, most recently from 6a4622a to 98e2366 Compare June 29, 2021 15:11
@vaspahomov
vaspahomov force-pushed the feature/vm-support branch from 98e2366 to ae67505 Compare July 1, 2021 09:32
Signed-off-by: vaspahomov <vas2142553@gmail.com>
@vaspahomov
vaspahomov force-pushed the feature/vm-support branch from ae67505 to 4276d56 Compare July 1, 2021 09:34
Signed-off-by: vaspahomov <vas2142553@gmail.com>
@ulucinar

Copy link
Copy Markdown
Collaborator

Hi @vaspahomov,
I think you have broken this PR into smaller ones such as #264, #269. If this is the case, let's get them in before this one.

@ulucinar
ulucinar self-requested a review September 22, 2021 09:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Azure VM Instances to provide MachineInstance support

2 participants