PublicIPAddress support

[vaspahomov]

Hello!

I want to add VM instances support in crossplane/provider-azure.

This is first part of big patch with Public IP addresses support

Description of your changes

Add support of Public IP Address.
Fixes #208

I have:

• Read and followed Crossplane's contribution process.
• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Same like in other resources like Subnet and VisrtualNetwork. And also manually tested

[ulucinar]

Suggested change

	o := managed.ExternalObservation{
	ResourceExists: true,
	ConnectionDetails: managed.ConnectionDetails{},
	}
	return o, nil
	return managed.ExternalObservation{
	ResourceExists: true,
	ResourceUpToDate: true,
	}, nil

We return ResourceUpToDate: true because I see that nothing can be updated in publicipaddress.external.Update. Is this really the case, can no fields be updated? What about tags?

[vaspahomov]

I've add todo about update support. It's not very often case for now

[ulucinar]

Thank you @vaspahomov for your work on this PR! Could you please rebase this PR and make sure all your commits are signed following the guide here. We also require them to be signed-off using something similar to git commit -s. git log --show-signature should display commit signatures.

[vaspahomov]

Hi @ulucinar thank you! I've commit fixes

[ulucinar]

Hi @vaspahomov,
Could you please sign your commit? git log --show-signature should show a signature. For example:

> git log --show-signature

commit aaaf3e9b1aa6b2aebe1a8a0ae52ea335353fe368 (HEAD -> feature/public-ip-address-support, vaspahomov/feature/public-ip-address-support)
Author: vaspahomov <vaspahomov@yandex-team.ru>
Date:   Fri Jun 18 15:21:30 2021 +0500

    PublicIPAddress support
    
    Signed-off-by: vaspahomov <vaspahomov@yandex-team.ru>
    Signed-off-by: vaspahomov <vas2142553@gmail.com>

commit 1c0702110ed45feabe2af15a0478e753d1c34d4e (stone-payments/master)
gpg: Signature made Cum 24 Eyl 15:21:04 2021 +03
gpg:                using RSA key 4AEE18F83AFDEB23
gpg: Good signature from "GitHub (web-flow commit signing) <noreply@github.com>" [full]
Merge: 33f728d 2cf7d16
Author: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Date:   Fri Sep 24 15:21:04 2021 +0300

    Merge pull request #293 from stone-payments/feature/add-public-access-in-postgresql
    
    Implement spec.publicNetworkAccess for PostgreSQL

It would be good if you could also remove the duplicate sign-off.

[ulucinar]

Hi @vaspahomov,
Per Crossplane API conventions, could you please move parameter fields here to their own PublicIPAddressParameters struct and add them under spec.forProvider here. For example:
https://github.com/crossplane/provider-azure/blob/3a2c932bb9e0557b72541f2ad851666b645de4cf/apis/database/v1beta1/configuration_types.go#L103

https://github.com/crossplane/provider-azure/blob/3a2c932bb9e0557b72541f2ad851666b645de4cf/apis/database/v1beta1/configuration_types.go#L56

[ulucinar]

Hi @vaspahomov,
Thank you for working on this PR. I'm planning to merge this and maybe address any remaining issues in a follow-up PR. What do you think?

[ulucinar]

Thank you very much @vaspahomov, merging this PR.

[ulucinar]

@vaspahomov, I've just opened a follow-up PR as discussed.