fix defaults not handled by yaml configuration#981
Merged
Conversation
ae5da24 to
e75f3bd
Compare
e75f3bd to
b2a19c4
Compare
Contributor
|
I like the idea of these being in their own section! I'm not sure I understand why it needs it's own struct though. It looks like the |
Owner
Author
That's because the configuration loader does not support tags with special chars like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #887
Current implementation of defaults is not working because the
model.Imagestruct does not support proper yaml and json tags for the configuration.Need a dedicated struct for this and also remove some fields that I don't think are necessary. Also move
imageDefaultsfrom watch todefaultsin config root.