-
Notifications
You must be signed in to change notification settings - Fork 76
feat: update go-ethereum to 1.16 #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
evmd/go.mod
Outdated
@@ -280,7 +280,7 @@ replace ( | |||
github.com/cosmos/evm => ../ | |||
github.com/cosmos/evm/evmd => ./evmd | |||
// use Cosmos geth fork | |||
github.com/ethereum/go-ethereum => github.com/cosmos/go-ethereum v1.15.11-cosmos-0 | |||
github.com/ethereum/go-ethereum => github.com/yihuang/go-ethereum v1.10.21-0.20250721081216-98795aa589d5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you upstream your changes to cosmos/go-ethereum
? We would be happy to integrate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to probably create a base release/1.16
branch first? Then I can create a PR to that branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yihuang I created https://github.com/cosmos/go-ethereum/tree/release/1.16 off of v1.16.2. Feel free to make a PR off of that :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
created cosmos/go-ethereum#7
@yihuang can you please link an existing github issue for this? If one does not exist, feel free to create one. We want to ensure that all PRs have an associated issue for context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after conflicts are resolved and we have the upcoming PR from @yihuang merged into https://github.com/cosmos/go-ethereum
update deps evmd update deps
Description
there are not much breaking changes.
Closes: #341
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
main
branchReviewers Checklist
All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.
I have...
Unreleased
section inCHANGELOG.md