Update to 1.12

.circleci/config.yml

@@ -17,8 +17,8 @@ commands:
       - run:
           name: Install Go
           command: |
-            wget https://dl.google.com/go/go1.11.5.linux-amd64.tar.gz
-            sudo tar -C /usr/local -xzf go1.11.5.linux-amd64.tar.gz
+            wget https://dl.google.com/go/go1.12.6.linux-amd64.tar.gz
+            sudo tar -C /usr/local -xzf go1.12.6.linux-amd64.tar.gz
             rm -rf go*.tar.gz
             echo 'export PATH=$PATH:/usr/local/go/bin' >> $BASH_ENV
             echo 'export PATH=$PATH:~/go/bin' >> $BASH_ENV
@@ -30,7 +30,7 @@ jobs:
     steps:
       - checkout
       - install-go
-      - run: GO111MODULE=off go get -u -v golang.org/x/lint/golint
+      - run: go get -u -v golang.org/x/lint/golint
       - run: sudo pip3 install black
       - run:
           name: Lint

Makefile

@@ -90,7 +90,7 @@ aws-clear-bucket:
 	@./dev/aws.sh clear-bucket
 
 tools:
-	@GO111MODULE=off go get -u -v golang.org/x/lint/golint
+	@go get -u -v golang.org/x/lint/golint
 	@go get -u -v github.com/VojtechVitek/rerun/cmd/rerun
 	@pip3 install black
 

build/cli.sh

@@ -32,7 +32,7 @@ function build_and_upload() {
 
   os=$1
   echo -e "\nBuilding Cortex CLI for $os"
-  GOOS=$os GOARCH=amd64 CGO_ENABLED=0 GO111MODULE=on go build -o cortex "$ROOT/cli"
+  GOOS=$os GOARCH=amd64 CGO_ENABLED=0 go build -o cortex "$ROOT/cli"
   if [ "$upload" == "true" ]; then
     echo "Uploading Cortex CLI to s3://$CLI_BUCKET_NAME/$CORTEX_VERSION/cli/$os/cortex"
     aws s3 cp cortex s3://$CLI_BUCKET_NAME/$CORTEX_VERSION/cli/$os/cortex --only-show-errors

build/test.sh

@@ -20,7 +20,7 @@ set -euo pipefail
 ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")"/.. >/dev/null && pwd)"
 
 function run_go_tests() {
-  (cd $ROOT && GO111MODULE=on go test ./... && echo "go tests passed")
+  (cd $ROOT && go test ./... && echo "go tests passed")
 }
 
 function run_python_tests() {

docs/development.md

@@ -2,7 +2,7 @@
 
 ## Prerequisites
 
-1. Go (>=1.11.5)
+1. Go (>=1.12.6)
 1. Docker
 1. eksctl
 1. kubectl

go.mod

@@ -1,64 +1,56 @@
-// locked dependency versions:
-//   github.com/GoogleCloudPlatform/spark-on-k8s-operator v1alpha1-0.5-2.4.0
-//   github.com/argoproj/argo v2.2.1
-//   k8s.io/client-go v10.0.0
-// go to the commit for the client-go release and browse to Godeps/Godeps.json to find these SHAs:
-//   k8s.io/api 89a74a8d264df0e993299876a8cde88379b940ee
-//   k8s.io/apimachinery 2b1284ed4c93a43499e781493253e2ac5959c4fd
-//
 // to update all:
+//   go clean -modcache (optional)
 //   rm go.mod go.sum
 //   go mod tidy
-//   (replace versions of locked dependencies above)
+//   replace these lines in go.mod:
+//     github.com/GoogleCloudPlatform/spark-on-k8s-operator v1alpha1-0.5-2.4.0
+//     github.com/argoproj/argo v2.3.0
+//     github.com/cortexlabs/yaml v2.2.2
+//     k8s.io/client-go v10.0.0
+//     k8s.io/api 89a74a8d264df0e993299876a8cde88379b940ee
+//     k8s.io/apimachinery 2b1284ed4c93a43499e781493253e2ac5959c4fd
+//       (note: go to the commit for the client-go release and browse to Godeps/Godeps.json to find the SHAs for k8s.io/api and k8s.io/apimachinery)
 //   go mod tidy
 //   check the diff in this file
 
 module github.com/cortexlabs/cortex
 
+go 1.12
+
 require (
 	github.com/GoogleCloudPlatform/spark-on-k8s-operator v0.0.0-20181208011959-62db1d66dafa
 	github.com/argoproj/argo v2.3.0+incompatible
-	github.com/aws/aws-sdk-go v1.16.17
+	github.com/aws/aws-sdk-go v1.20.5
 	github.com/cortexlabs/yaml v0.0.0-20190530233410-11baebde6c89
 	github.com/davecgh/go-spew v1.1.1
-	github.com/emicklei/go-restful v2.8.0+incompatible // indirect
-	github.com/go-openapi/spec v0.18.0 // indirect
-	github.com/gogo/protobuf v1.2.0 // indirect
-	github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b // indirect
-	github.com/google/btree v0.0.0-20180813153112-4030bb1f1f0c // indirect
-	github.com/google/gofuzz v0.0.0-20170612174753-24818f796faf // indirect
-	github.com/googleapis/gnostic v0.2.0 // indirect
-	github.com/gorilla/context v1.1.1 // indirect
-	github.com/gorilla/mux v1.6.2
+	github.com/emicklei/go-restful v2.9.6+incompatible // indirect
+	github.com/go-openapi/spec v0.19.2 // indirect
+	github.com/gogo/protobuf v1.2.1 // indirect
+	github.com/google/btree v1.0.0 // indirect
+	github.com/google/gofuzz v1.0.0 // indirect
+	github.com/googleapis/gnostic v0.3.0 // indirect
+	github.com/gorilla/mux v1.7.2
 	github.com/gorilla/websocket v1.4.0
-	github.com/gregjones/httpcache v0.0.0-20181110185634-c63ab54fda8f // indirect
-	github.com/imdario/mergo v0.3.6 // indirect
-	github.com/inconshreveable/mousetrap v1.0.0 // indirect
-	github.com/json-iterator/go v1.1.5 // indirect
-	github.com/kr/pretty v0.1.0 // indirect
-	github.com/mitchellh/go-homedir v1.0.0
-	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
+	github.com/gregjones/httpcache v0.0.0-20190611155906-901d90724c79 // indirect
+	github.com/imdario/mergo v0.3.7 // indirect
+	github.com/json-iterator/go v1.1.6 // indirect
+	github.com/mitchellh/go-homedir v1.1.0
 	github.com/modern-go/reflect2 v1.0.1 // indirect
 	github.com/peterbourgon/diskv v2.0.1+incompatible // indirect
 	github.com/pkg/errors v0.8.1
-	github.com/spf13/cobra v0.0.3
-	github.com/spf13/pflag v1.0.3 // indirect
+	github.com/spf13/cobra v0.0.5
 	github.com/stretchr/testify v1.3.0
 	github.com/tcnksm/go-input v0.0.0-20180404061846-548a7d7a8ee8
-	github.com/ugorji/go/codec v0.0.0-20181209151446-772ced7fd4c2
+	github.com/ugorji/go/codec v1.1.5-pre
 	github.com/xlab/treeprint v0.0.0-20181112141820-a009c3971eca
-	golang.org/x/crypto v0.0.0-20190103213133-ff983b9c42bc // indirect
-	golang.org/x/net v0.0.0-20190110200230-915654e7eabc // indirect
-	golang.org/x/oauth2 v0.0.0-20190110195249-fd3eaa146cbb // indirect
-	golang.org/x/sys v0.0.0-20190109145017-48ac38b7c8cb // indirect
-	golang.org/x/time v0.0.0-20181108054448-85acf8d2951c // indirect
-	gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127 // indirect
+	golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45 // indirect
+	golang.org/x/time v0.0.0-20190308202827-9d24e82272b4 // indirect
 	gopkg.in/inf.v0 v0.9.1 // indirect
 	gopkg.in/robfig/cron.v2 v2.0.0-20150107220207-be2e0b0deed5
 	k8s.io/api v0.0.0-20181204000039-89a74a8d264d
 	k8s.io/apimachinery v0.0.0-20181127025237-2b1284ed4c93
 	k8s.io/client-go v10.0.0+incompatible
-	k8s.io/klog v0.1.0 // indirect
-	k8s.io/kube-openapi v0.0.0-20181114233023-0317810137be // indirect
+	k8s.io/klog v0.3.0 // indirect
+	k8s.io/kube-openapi v0.0.0-20190603182131-db7b694dc208 // indirect
 	sigs.k8s.io/yaml v1.1.0 // indirect
 )