Skip to content

Update to 1.12 #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2019
Merged

Update to 1.12 #170

merged 1 commit into from
Jun 21, 2019

Conversation

deliahu
Copy link
Member

@deliahu deliahu commented Jun 21, 2019 •
edited
Loading

Closes #169

Checklist:

  • Run make test and make lint
  • Test end to end manually (e.g. build/push all images, restart local operator, and run cx refresh in an example folder)
  • Update documentation
  • Update examples and cx init
  • Alert team if dev environment changed
  • Cherry-pick into release branches if it's a bugfix
  • Delete the branch once it's merged

@deliahu deliahu requested a review from vishalbollu June 21, 2019 18:22
vishalbollu
vishalbollu approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@vishalbollu vishalbollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deliahu deliahu merged commit 5f27966 into master Jun 21, 2019
@deliahu deliahu deleted the update-go-1.12 branch June 21, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalbollu vishalbollu vishalbollu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to go 1.12
2 participants
@deliahu @vishalbollu