-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
fix: update Pulse scripts for v4 Go rewrite support #6574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update install script to download universal package - Update update_script to preserve data directory during updates - Remove Node.js dependencies and use built-in installer - Scripts now support v4 (Go) architecture
There, fixed it for ya @rcourtman :), you should do the same for the ct script |
- Use fetch_and_deploy_gh_release as requested - Add architecture detection for multi-arch support - Simplify update script to use helper functions - Remove unnecessary code and keep it minimal
Thanks for the feedback @MickLesk! I've updated the PR to use the helper functions as requested: ✅ Now uses The script now properly handles all architectures that Pulse supports while using your helper functions. |
Quick update needed: The environment variable should be For the helper script, just change: -Environment="PULSE_CONFIG_DIR=/etc/pulse"
+Environment="PULSE_DATA_DIR=/etc/pulse" This ensures Pulse knows where to store its data. The default is /etc/pulse anyway, but being explicit is good. |
Changed from PULSE_CONFIG_DIR to PULSE_DATA_DIR to match what Pulse v4.0.3 actually uses. The default is /etc/pulse anyway, but being explicit ensures consistency.
Fixed! Changed to |
a2866e1
@CrazyWolf13 pushed an update with the version file creation in ~/.pulse To clarify on your questions:
|
hey @MickLesk @CrazyWolf13 - thanks for the quick merge and feedback on this noticed the docs site at https://community-scripts.github.io/ProxmoxVE/scripts?id=pulse still shows old v3 info. needs updating:
where does the site pull this info from? couldn't find it in the repo. happy to update it if you point me to the right place |
its your cache, at my system are 4.0.3. but the json can be fixed in next time |
✍️ Description
Updates Pulse installation scripts to support v4, which is a complete rewrite in Go. The current scripts attempt to install v4 as a Node.js application, resulting in broken installations.
What this fixes:
Why this is critical:
🔗 Related PR / Issue
Link: #6568 (previous PR closed for template/formatting issues)
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README
,AppName.md
,CONTRIBUTING.md
, or other docs.Testing performed: