fix(pulse): Update Pulse scripts to support v4 Go rewrite #6568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove v3 detection logic since latest release is now v4+ - Use universal package and built-in installer - Update script preserves data directory during updates - Simplified scripts since v3 is no longer the latest
rcourtman
force-pushed
the
pulse-v4-update
branch
from
2058580 to
cdd4141
Compare
|
Can you remove all comments? Maybe its better to Switch to our helper function (fetch_deploy...) |
- Remove all comments from pulse-install.sh - Remove comments from update_script in ct/pulse.sh - Keep code minimal and clean per community-scripts standards
|
Thanks for the review @MickLesk! I've updated the PR to address your feedback: ✅ Removed all comments from both scripts The scripts now follow the same pattern as other recent additions to the repository. |
|
pls rewrite your PR description to use our PR template. (it is there for a reason...) |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the Pulse installation and update scripts to properly support Pulse v4, which is a complete rewrite in Go.
Changes
install/pulse-install.shct/pulse.shupdate_script()function to handle both v3 and v4Testing
Context
Pulse v4 is a complete rewrite from Node.js to Go, offering:
The scripts now automatically detect the version and use the appropriate installation method.
Fixes the issue where the current script tries to install v4 as a Node.js application, resulting in a broken installation.