Conversation
Contributor
|
@folix-01 Is it possible to enable/disable this feature? Globally or specifically for each form? |
Member
Author
All this logics already working on master, the main target of this pr is to move the otp validation logics to another package. As i remember the otp validation is inevitable if u have email in bcc fields, if we want to change this, it may be target of another pr |
mamico
approved these changes
Jun 17, 2024
ebd0690 to
6d8b06d
Compare
Member
Author
|
@sneridagh Can we merge this before we pass to the new setup ? |
Member
Contributor
|
As depicted in the comments above, it appears that there are no real changes, but some code moved outside for future code reuse. It's ok for me. I consider #57 important, but the issue was not started here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logics moved here : https://github.com/collective/collective.volto.otp to be reusable