Skip to content

Resect email otp logics#56

Merged
folix-01 merged 6 commits intomainfrom
resect_otp_logics
Jul 23, 2024
Merged

Resect email otp logics#56
folix-01 merged 6 commits intomainfrom
resect_otp_logics

Conversation

@folix-01
Copy link
Member

@folix-01 folix-01 commented Jun 13, 2024

@folix-01 folix-01 requested review from cekk and mamico June 13, 2024 13:16
@mamico mamico removed request for cekk and mamico June 13, 2024 13:19
@mamico mamico marked this pull request as draft June 13, 2024 13:19
@folix-01 folix-01 marked this pull request as ready for review June 13, 2024 13:25
@folix-01 folix-01 changed the title Resect otp logics Resect email otp logics Jun 13, 2024
@folix-01 folix-01 requested review from cekk and mamico June 13, 2024 13:26
@mamico
Copy link
Contributor

mamico commented Jun 13, 2024

@folix-01 Is it possible to enable/disable this feature? Globally or specifically for each form?

@folix-01
Copy link
Member Author

@folix-01 Is it possible to enable/disable this feature? Globally or specifically for each form?

All this logics already working on master, the main target of this pr is to move the otp validation logics to another package.

As i remember the otp validation is inevitable if u have email in bcc fields, if we want to change this, it may be target of another pr

@folix-01 folix-01 force-pushed the resect_otp_logics branch from ebd0690 to 6d8b06d Compare July 10, 2024 10:44
@folix-01
Copy link
Member Author

@sneridagh Can we merge this before we pass to the new setup ?

@sneridagh
Copy link
Member

@folix-01 as long as @pnicolli and @mamico approve it and merge it, is fine, I will rebase. BTW, I didn't check this PR or what is for.

@mamico
Copy link
Contributor

mamico commented Jul 11, 2024

As depicted in the comments above, it appears that there are no real changes, but some code moved outside for future code reuse. It's ok for me.

I consider #57 important, but the issue was not started here.

@folix-01 folix-01 merged commit 33137ad into main Jul 23, 2024
@folix-01 folix-01 self-assigned this Aug 26, 2024
@folix-01 folix-01 deleted the resect_otp_logics branch August 26, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants