Skip to content

Resect email otp logics #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
folix-01 merged 6 commits into from
Jul 23, 2024
Merged

Resect email otp logics #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be0cc92
Remove otp logics
folix-01 Jun 12, 2024
47845fe
Docs
folix-01 Jun 12, 2024
625dc97
restart ci
folix-01 Jun 13, 2024
137b769
Update buildout
folix-01 Jun 13, 2024
3d16a5d
Update setup
folix-01 Jun 13, 2024
6d8b06d
remove extras
folix-01 Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Changelog
- Configurable header and footer for email message.
[folix-01]
- Subject templating
- Remove otp logics (moved to collective.volto.otp)
[folix-01]
- Handle the edge cases where the `blocks` attribute is not set.
[mamico]
Expand Down
27 changes: 0 additions & 27 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,33 +106,6 @@ Optional parameters could be passed in the payload:
* `block_id` to delete only data related to a specific block on the page, otherwise data from all form blocks on the page will be deleted
* `expired` a boolean that, if `true`, removes only records older than the value of days specified in the block configuration (the above `block_id` parameter is required)

@validate-email-address
-----------------------

Send an message to the passed email with OTP code to verify the address.
Returns a HTTP 204 in case of success or HTTP 400 in case the email is badly composed.::

> curl -i -X POST http://localhost:8080/Plone/my-form/@validate-email-address --data-raw '{"email": "email@email.com", "uid": "ffffffff"}' -H 'Accept: application/json' -H 'Content-Type: application/json'

parameters:

* `email` email address.
* `uid` uid related to email field

@validate-email-token
---------------------

Supposed to validate the OTP code received by the user via email.
Returns HTTP 204 in case of success or HTTP 400 in case of failure ::

> curl -i -X POST http://localhost:8080/Plone/my-form/@validate-email-token --data-raw '{"email": "email@email.com", "otp": "blahblahblah"}' -H 'Accept: application/json' -H 'Content-Type: application/json'

parameters:

* `email` email address
* `uid` uid used to generate the OTP
* `otp` OTP code

Form actions
============

Expand Down
3 changes: 1 addition & 2 deletions base.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ eggs =
Plone
Pillow
collective.volto.formsupport [test]
plone.keyring

zcml-additional +=
<configure xmlns="http://namespaces.zope.org/zope"
Expand Down Expand Up @@ -126,7 +125,7 @@ scripts =
[versions]
# Don't use a released version of collective.volto.formsupport
collective.volto.formsupport =
setuptools =
setuptools =

[sources]

3 changes: 1 addition & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@
"Zope",
"plone.api>=1.8.4",
"plone.dexterity",
"plone.keyring",
"plone.i18n",
"plone.memoize",
"plone.protect",
Expand All @@ -69,7 +68,7 @@
"souper.plone",
"click",
"beautifulsoup4",
"pyotp",
"collective.volto.otp",
],
extras_require={
"hcaptcha": [
Expand Down
8 changes: 0 additions & 8 deletions src/collective/volto/formsupport/browser/configure.zcml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,5 @@
template="send_mail_template_table.pt"
permission="zope2.View"
/>
<browser:page
name="email-confirm-view"
for="*"
class=".email_confirm_view.EmailConfirmView"
template="templates/email_confirm_view.pt"
permission="zope2.View"
layer="collective.volto.formsupport.interfaces.ICollectiveVoltoFormsupportLayer"
/>

</configure>
18 changes: 0 additions & 18 deletions src/collective/volto/formsupport/browser/email_confirm_view.py
View file
Open in desktop

This file was deleted.

Loading