Skip to content

docs: add "Creating Composer Packages" #7742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jul 28, 2023

Description

  • add "Creating Composer Packages"

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the documentation Pull requests for documentation only label Jul 28, 2023
@kenjis kenjis force-pushed the docs-extending/composer_packages.rst branch 3 times, most recently from c25e62b to 5850f1e Compare July 28, 2023 01:55
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice coverage. Please also plug the DevKit, which is designed to work with CodeIgniter packages - maybe even add it to the example require-dev section?

@kenjis
Copy link
Member Author

kenjis commented Jul 29, 2023

@MGatner Added about DevKit.

@kenjis kenjis requested a review from MGatner July 29, 2023 00:33
Copy link
Contributor

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR to improve the growing community of plugin developers CodeIgniter4.

The same content that took me a long time to get to know the package development process for CodeIgniter4.

This PR led me to an idea that I had in mind a long time ago.

Create a new command on the command line to create an blank package for codeigniter.

I think the presence of such a command helps the developer to spend less time and more interest in releasing a new package for the Codegniter community to use. The same topic that is published in many articles about the lack of packages for CodeIgniter4.

@kenjis kenjis force-pushed the docs-extending/composer_packages.rst branch from fbe8528 to add666c Compare July 31, 2023 00:56
@kenjis kenjis requested a review from paulbalandan July 31, 2023 01:08
@kenjis kenjis mentioned this pull request Jul 31, 2023
3 tasks
@kenjis kenjis requested a review from paulbalandan July 31, 2023 04:10
Copy link

@TimexPeachtree TimexPeachtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@kenjis kenjis merged commit 87454e6 into codeigniter4:develop Jul 31, 2023
@kenjis kenjis deleted the docs-extending/composer_packages.rst branch July 31, 2023 06:24
@kenjis
Copy link
Member Author

kenjis commented Jul 31, 2023

Thank you all for reviews!

@MGatner
Copy link
Member

MGatner commented Aug 2, 2023

Create a new command on the command line to create an blank package for codeigniter.

@datamweb I would love to see someone leverage GitHub's repository template feature to handle this instead. I think most of the functionality is all there, and whatever is left could be a script included in the repo to handle things like setting the vendor name.

@kenjis
Copy link
Member Author

kenjis commented Aug 2, 2023

There is a repository like that.
https://github.com/koriym/Koriym.PhpSkeleton

@datamweb
Copy link
Contributor

datamweb commented Aug 2, 2023

I would love to see someone leverage GitHub's repository template feature to handle this instead. I think most of the functionality is all there, and whatever is left could be a script included in the repo to handle things like setting the vendor name.

@MGatner Thank you for feedback, is this what you mean?
https://docs.github.com/en/repositories/creating-and-managing-repositories/creating-a-template-repository

@MGatner
Copy link
Member

MGatner commented Aug 3, 2023

@datamweb yes, precisely! Though the repo @kenjis linked looks like it would have some helpful code too. Maybe some kind of hybrid project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests for documentation only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants