-
Notifications
You must be signed in to change notification settings - Fork 744
feat(adk): align filesystem backend FileInfo.Path field behavior with Python glob and ls command #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(adk): align filesystem backend FileInfo.Path field behavior with Python glob and ls command #767
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ import ( | |
|
|
||
| // FileInfo represents basic file metadata information. | ||
| type FileInfo struct { | ||
| // Path is the absolute path of the file or directory. | ||
| // Path is the path of the file or directory, which can be a filename, relative path, or absolute path. | ||
| Path string | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚨 Breaking API Changes Detected Package: Incompatible changes:
Review GuidelinesPlease ensure that:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚨 Breaking API Changes Detected Package: Incompatible changes:
Review GuidelinesPlease ensure that:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚨 Breaking API Changes Detected Package: Incompatible changes:
Review GuidelinesPlease ensure that:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🚨 Breaking API Changes Detected Package: Incompatible changes:
Review GuidelinesPlease ensure that:
|
||
|
|
||
| // IsDir indicates whether the entry is a directory. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 Breaking API Changes Detected
Package:
github.com/cloudwego/eino/adk/middlewares/reductionIncompatible changes:
Review Guidelines
Please ensure that: