Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| type FileInfo struct { | ||
| // Path is the absolute path of the file or directory. | ||
| // Path is the path of the file or directory, which can be a filename, relative path, or absolute path. | ||
| Path string |
There was a problem hiding this comment.
🚨 Breaking API Changes Detected
Package: github.com/cloudwego/eino/adk/middlewares/reduction
Incompatible changes:
- New: removed
Review Guidelines
Please ensure that:
- The changes are absolutely necessary
- They are properly documented
- Migration guides are provided if needed
| type FileInfo struct { | ||
| // Path is the absolute path of the file or directory. | ||
| // Path is the path of the file or directory, which can be a filename, relative path, or absolute path. | ||
| Path string |
There was a problem hiding this comment.
🚨 Breaking API Changes Detected
Package: github.com/cloudwego/eino/adk/middlewares/patchtoolcalls
Incompatible changes:
- Config: removed
- NewMiddleware: removed
Review Guidelines
Please ensure that:
- The changes are absolutely necessary
- They are properly documented
- Migration guides are provided if needed
| type FileInfo struct { | ||
| // Path is the absolute path of the file or directory. | ||
| // Path is the path of the file or directory, which can be a filename, relative path, or absolute path. | ||
| Path string |
There was a problem hiding this comment.
🚨 Breaking API Changes Detected
Package: github.com/cloudwego/eino/adk/middlewares/skill
Incompatible changes:
- NewChatModelAgentMiddleware: removed
Review Guidelines
Please ensure that:
- The changes are absolutely necessary
- They are properly documented
- Migration guides are provided if needed
| type FileInfo struct { | ||
| // Path is the absolute path of the file or directory. | ||
| // Path is the path of the file or directory, which can be a filename, relative path, or absolute path. | ||
| Path string |
There was a problem hiding this comment.
🚨 Breaking API Changes Detected
Package: github.com/cloudwego/eino/adk/middlewares/filesystem
Incompatible changes:
- New: removed
Review Guidelines
Please ensure that:
- The changes are absolutely necessary
- They are properly documented
- Migration guides are provided if needed
| type FileInfo struct { | ||
| // Path is the absolute path of the file or directory. | ||
| // Path is the path of the file or directory, which can be a filename, relative path, or absolute path. | ||
| Path string |
There was a problem hiding this comment.
🚨 Breaking API Changes Detected
Package: github.com/cloudwego/eino/adk/middlewares/summarization
Incompatible changes:
- Config.ModelOptions: removed
Review Guidelines
Please ensure that:
- The changes are absolutely necessary
- They are properly documented
- Migration guides are provided if needed
zhuangjie1125
force-pushed
the
feat/filesystemv4
branch
from
0faa693 to
7cb8aaf
Compare
| input: `{"path": "/"}`, | ||
| expected: []string{"/file1.txt", "/file2.go", "/dir1", "/dir2"}, | ||
| expected: []string{"file1.txt", "file2.go", "dir1", "dir2"}, | ||
| }, |
There was a problem hiding this comment.
🚨 Breaking API Changes Detected
Package: github.com/cloudwego/eino/adk/middlewares/filesystem
Incompatible changes:
- New: removed
Review Guidelines
Please ensure that:
- The changes are absolutely necessary
- They are properly documented
- Migration guides are provided if needed
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## alpha/08 #767 +/- ##
============================================
- Coverage 79.88% 79.86% -0.03%
============================================
Files 146 146
Lines 15806 15813 +7
============================================
+ Hits 12627 12629 +2
- Misses 2197 2202 +5
Partials 982 982 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhuangjie1125
force-pushed
the
feat/filesystemv4
branch
2 times, most recently
from
b5fb907 to
134c7f1
Compare
…lob and ls command Enhanced the filesystem backend to align Path field behavior with Python glob patterns and standard ls command output. Also improved documentation for enhanced tool call wrapper methods. Key Changes: 1. Updated FileInfo.Path field documentation: - Changed from "absolute path only" to support filename, relative path, or absolute path - Clarified that Path value depends on the command context (Ls vs Glob) 2. Modified LsInfo implementation: - Returns only filename/directory name instead of full path - Uses filepath.Base() for file entries - Uses parts[0] for immediate children in directory listings - Behavior now matches standard ls command output 3. Enhanced GlobInfo with Python glob compatibility: - Replaced custom recursive matching with github.com/bmatcuk/doublestar/v4 library - Implemented ** (double star) support for recursive directory traversal - Added absolute pattern detection (patterns starting with /) - Absolute patterns return absolute paths; relative patterns return relative paths - Supports ** in any position: beginning, middle, or end of pattern 4. Comprehensive test coverage: - Added TestInMemoryBackend_LsInfo_PathIsFilename: validates Ls returns filenames only - Added TestInMemoryBackend_GlobInfo_RelativePath: tests relative/absolute pattern behavior - Added TestInMemoryBackend_GlobInfo_RecursivePattern: validates ** recursive matching - Updated existing tests to match new Path field behavior 5. Documentation improvements: - Added comprehensive documentation for WrapEnhancedInvokableToolCall method - Added comprehensive documentation for WrapEnhancedStreamableToolCall method - Documentation follows the same pattern as existing WrapInvokableToolCall and WrapStreamableToolCall methods Technical Implementation: - Uses doublestar.Match() for robust glob pattern matching with ** support - Pattern matching handles complex patterns like "**/*.go", "src/**/*.go" - Absolute patterns (starting with /) bypass basePath filtering and return full paths - Relative patterns respect basePath and return paths relative to it Impact: - Ls command now returns clean filenames like standard Unix ls - Glob patterns behave identically to Python glob.glob() with recursive=True - Supports complex patterns like "**/*.go", "src/**/*.go", and "/absolute/path/**/*.go" - Enhanced tool wrapper methods are now properly documented for middleware developers
zhuangjie1125
force-pushed
the
feat/filesystemv4
branch
from
134c7f1 to
206e940
Compare
… Python glob and ls command (#767)
2 participants
Enhanced the filesystem backend to align Path field behavior with Python glob patterns and standard ls command output.
Key Changes:
Updated FileInfo.Path field documentation:
Modified LsInfo implementation:
Enhanced GlobInfo with Python glob compatibility:
Comprehensive test coverage:
Technical Implementation:
Impact: