Skip to content

fix(deep): add GenModelInput to general subagent in task tool#743

Merged
hi-pender merged 2 commits intomainfrom
fix/deep-task-tool-gen-model-input
Feb 3, 2026
Merged

fix(deep): add GenModelInput to general subagent in task tool#743
hi-pender merged 2 commits intomainfrom
fix/deep-task-tool-gen-model-input

Conversation

@hi-pender
Copy link
Contributor

Summary

This PR fixes a missing GenModelInput configuration in the general subagent created within task_tool.go.

Background

In the previous PR (#726), we added a custom genModelInput function to DeepAgent to disable automatic instruction rendering from session values. However, the general subagent created in task_tool.go was missed and still uses the default GenModelInput which performs automatic rendering.

Changes

1. Fix task_tool.go

  • Added GenModelInput: genModelInput to the ChatModelAgentConfig for the general subagent
  • This ensures consistent behavior with the main DeepAgent

2. Update .commit-rules.json

  • Added new scopes: deep, skill, filesystem
  • These scopes are needed for commits related to the respective modules

Testing

All existing tests pass:

go test ./adk/prebuilt/deep/... -v

@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.70%. Comparing base (f2c03c3) to head (daea16c).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
adk/prebuilt/deep/task_tool.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
- Coverage   81.78%   81.70%   -0.09%     
==========================================
  Files         129      129              
  Lines       12426    12427       +1     
==========================================
- Hits        10163    10153      -10     
- Misses       1509     1518       +9     
- Partials      754      756       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hi-pender hi-pender force-pushed the fix/deep-task-tool-gen-model-input branch from 0b8a69e to 4bd4ea5 Compare February 3, 2026 13:13
@hi-pender hi-pender merged commit 6b8a737 into main Feb 3, 2026
17 checks passed
@hi-pender hi-pender deleted the fix/deep-task-tool-gen-model-input branch February 3, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants