fix(adk): disable automatic instruction rendering in DeepAgent#726
Merged
fix(adk): disable automatic instruction rendering in DeepAgent#726
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
==========================================
- Coverage 81.82% 81.75% -0.08%
==========================================
Files 129 129
Lines 12416 12423 +7
==========================================
- Hits 10160 10157 -3
- Misses 1500 1510 +10
Partials 756 756 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shentongmartin
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR customizes the
GenModelInputfunction forDeepAgentto disable automatic instruction rendering from session values.Background
The default
GenModelInputinChatModelAgentautomatically retrieves session values viaGetSessionValues(ctx)and renders placeholders in the instruction usingprompt.FromMessages. While this feature is explicitly documented and exposed inChatModelAgent, it can be confusing forDeepAgentusers who may not be aware of this implicit behavior.Changes
genModelInputfunction in the deep package that simply combines the instruction and messages without template renderingDeepAgentto use this custom function instead of the default oneImpact
DeepAgentwill no longer automatically render instruction placeholders from session valuesChatModelAgentdirectly with its default behavior