Skip to content

some cases htmlparser2 cant be used for html rendering#1815

Closed
5saviahv wants to merge 1 commit intocheeriojs:mainfrom
5saviahv:pr/fix
Closed

some cases htmlparser2 cant be used for html rendering#1815
5saviahv wants to merge 1 commit intocheeriojs:mainfrom
5saviahv:pr/fix

Conversation

@5saviahv
Copy link
Copy Markdown
Contributor

small fix that allows using htmlparser2 for html rendering, when html string was provided.

@bodinsamuel
Copy link
Copy Markdown

bodinsamuel commented Apr 30, 2021

hey @fb55 can you take a look at this please? ☺️
related to #1627

@fb55
Copy link
Copy Markdown
Member

fb55 commented Apr 30, 2021

@bodinsamuel This was also fixed in #1816, and I want to move forward with that PR. I am still waiting a few more days for people to review it, but unless someone brings up any issues, I should be able to issue a new release some time next week.

@bodinsamuel
Copy link
Copy Markdown

oh, amazing news and congrats on jumping on the TS wagon 💪🏻
Can't wait for the update then 🙏🏻

@fb55
Copy link
Copy Markdown
Member

fb55 commented May 6, 2021

Closing this as it has been fixed in #1816. Thanks a lot @5saviahv!

@fb55 fb55 closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants