Skip to content

.html() send context to parse5#1627

Merged
fb55 merged 2 commits intocheeriojs:mainfrom
5saviahv:parse5-context
Jan 1, 2021
Merged

.html() send context to parse5#1627
fb55 merged 2 commits intocheeriojs:mainfrom
5saviahv:parse5-context

Conversation

@5saviahv
Copy link
Copy Markdown
Contributor

@5saviahv 5saviahv commented Jan 1, 2021

using proper context when parsing in .html()

It solves #1083

@5saviahv 5saviahv added the javascript Pull requests that update Javascript code label Jan 1, 2021
@fb55 fb55 merged commit bf04330 into cheeriojs:main Jan 1, 2021
@fb55
Copy link
Copy Markdown
Member

fb55 commented Jan 1, 2021

Great job @5saviahv!

@5saviahv 5saviahv deleted the parse5-context branch January 1, 2021 18:23
@bodinsamuel
Copy link
Copy Markdown

Hello, this seems to break when used in combinaison with _useHtmlParser2
I know htmlParser2 is somewhat hidden so, is it fixable or is it expected/won't fix? ☺️

https://runkit.com/embed/kv9cok8uese9

@5saviahv
Copy link
Copy Markdown
Contributor Author

hmm, it seems to be my mistake/typo

@bodinsamuel
Copy link
Copy Markdown

Thanks @5saviahv 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

3 participants