Skip to content

Commit fcbd7bb

Browse files
author
Jianchun Xu
committed
[MERGE #1313 @jianchun] split ChakraCoreVersion.h file
Merge pull request #1313 from jianchun:chakracoreversion Split version defs out from `CommonDefines.h` into a separate file. Hosts that statically link to ChakraCore can then access ChakraCore version info by `#include` this file at build time.
2 parents 5df61db + 3dc5f77 commit fcbd7bb

File tree

2 files changed

+16
-13
lines changed

2 files changed

+16
-13
lines changed

lib/Common/ChakraCoreVersion.h

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
//-------------------------------------------------------------------------------------------------------
2+
// Copyright (C) Microsoft. All rights reserved.
3+
// Licensed under the MIT license. See LICENSE.txt file in the project root for full license information.
4+
//-------------------------------------------------------------------------------------------------------
5+
#pragma once
6+
7+
#define CHAKRA_CORE_MAJOR_VERSION 1
8+
#define CHAKRA_CORE_MINOR_VERSION 2
9+
#define CHAKRA_CORE_VERSION_RELEASE 0
10+
#define CHAKRA_CORE_VERSION_PRERELEASE 0
11+
#define CHAKRA_CORE_VERSION_RELEASE_QFE 0
12+
13+
#define CHAKRA_VERSION_RELEASE 0
14+
15+
// NOTE: need to update the GUID in ByteCodeCacheReleaseFileVersion.h as well

lib/Common/CommonDefines.h

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,7 @@
66

77
#include "TargetVer.h"
88
#include "Warnings.h"
9-
10-
//----------------------------------------------------------------------------------------------------
11-
// Chakra Core version
12-
//----------------------------------------------------------------------------------------------------
13-
#define CHAKRA_CORE_MAJOR_VERSION 1
14-
#define CHAKRA_CORE_MINOR_VERSION 2
15-
#define CHAKRA_CORE_VERSION_RELEASE 0
16-
#define CHAKRA_CORE_VERSION_PRERELEASE 0
17-
#define CHAKRA_CORE_VERSION_RELEASE_QFE 0
18-
19-
#define CHAKRA_VERSION_RELEASE 0
20-
21-
// NOTE: need to update the GUID in ByteCodeCacheReleaseFileVersion.h as well
9+
#include "ChakraCoreVersion.h"
2210

2311
//----------------------------------------------------------------------------------------------------
2412
// Default debug/fretest/release flags values

0 commit comments

Comments
 (0)