Skip to content

feat: warning about folders public links #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

feat: warning about folders public links #178

wants to merge 4 commits into from

Conversation

rodcoffani
Copy link

  • warning (text or modal) triggered when creating an Editor link for a folder
  • add a maxDate property on oc-datepicker component
  • set default expiration dates for Editor links on folders

diocas
diocas requested changes Mar 14, 2025
View reviewed changes
@rodcoffani rodcoffani force-pushed the feat/warning-rw-links branch from f09e172 to 0fe0b30 Compare March 24, 2025 09:47
@rodcoffani
Copy link
Author

the capability store still needs to be updated in the backend

diocas pushed a commit that referenced this pull request Mar 31, 2025
@JammingBen
Merge pull request #178 from opencloud-eu/renovate/babel-monorepo
11c2187 
chore(deps): update babel monorepo to v7.26.9
diocas
diocas requested changes Apr 1, 2025
View reviewed changes
@rodcoffani rodcoffani force-pushed the feat/warning-rw-links branch from 888f4ef to a598d92 Compare April 23, 2025 08:56
@rodcoffani rodcoffani requested a review from diocas April 25, 2025 06:52
@rodcoffani
feat: add a maxDate prop on datepicker
879d1f2
@rodcoffani
feat: default expiration dates
bb251ed 
- folders expiration date defined in capability store
- if the expiration is set for more than the maximum defined, is updated
- removes the option to unset expiration dates for RW folders
@rodcoffani
feat: warning for folders public links
fc6ff2b 
- only for folders with RW permissions
- modal or div, based on if it was created or updated
- alert message defined in config store by language
- check if message exists before showing
@rodcoffani rodcoffani force-pushed the feat/warning-rw-links branch from a598d92 to 6b8f39d Compare April 30, 2025 14:51
@rodcoffani
Copy link
Author

the capability store still needs to be updated in the backend

cs3org/reva#5158

diocas
diocas requested changes Jun 26, 2025
View reviewed changes
@rodcoffani rodcoffani force-pushed the feat/warning-rw-links branch from 6b8f39d to 1d866f5 Compare July 1, 2025 08:04
@rodcoffani rodcoffani requested a review from diocas July 1, 2025 08:04
diocas
diocas approved these changes Jul 1, 2025
View reviewed changes
Copy link

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh, just one tiny tiny change and we merge :)

diocas
diocas requested changes Jul 1, 2025
View reviewed changes
Copy link

@diocas diocas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Force of habit... sorry

@rodcoffani rodcoffani force-pushed the feat/warning-rw-links branch from 1d866f5 to 4590f60 Compare July 2, 2025 12:09
@rodcoffani
Copy link
Author

rodcoffani commented Jul 2, 2025 •
edited
Loading

Note: also updated piniaStores/config/types.ts to z.record() instead of z.object(), this way the keys and values are dynamic defined.

@rodcoffani rodcoffani requested a review from diocas July 2, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diocas diocas Awaiting requested review from diocas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodcoffani @diocas