feat: default expiration dates

- default expiration date for folders with RW permissions is 30 days
- if the expiration date is set for more than 3 years, is updated
- removes the option to unset expiration dates for RW folders

Author: rodcoffani

packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue

@@ -102,6 +102,7 @@ import { isLocationSharesActive, useSharesStore } from '@ownclouders/web-pkg'
 import { useGettext } from 'vue3-gettext'
 import { storeToRefs } from 'pinia'
 import { SharingLinkType } from '@ownclouders/web-client/graph/generated'
+import { DateTime } from 'luxon'
 
 export default defineComponent({
   name: 'FileLinks',
@@ -192,6 +193,22 @@ export default defineComponent({
       options: UpdateLinkOptions['options']
     }) => {
       try {
+        // default expiration date
+        if (unref(resource).isFolder && options.type === 'edit' && !linkShare.expirationDateTime) {
+          Object.assign(options, {
+            ...options,
+            expirationDateTime: DateTime.now().plus({ days: 30 }).endOf('day').toISO()
+          })
+        }
+        // expiration date capped at 3 years
+        if (unref(resource).isFolder && linkShare.expirationDateTime) {
+          if (DateTime.fromISO(linkShare.expirationDateTime).diffNow('years').years > 3) {
+            Object.assign(options, {
+              ...options,
+              expirationDateTime: DateTime.now().plus({ years: 3 }).endOf('day').toISO()
+            })
+          }
+        }
         await updateLink({
           clientService,
           space: unref(space),

packages/web-app-files/src/components/SideBar/Shares/Links/EditDropdown.vue

@@ -110,7 +110,11 @@ export default defineComponent({
         customComponent: DatePickerModal,
         customComponentAttrs: () => ({
           currentDate: currentDate.isValid ? currentDate : null,
-          minDate: DateTime.now()
+          minDate: DateTime.now(),
+          maxDate:
+            resource.value.isFolder && props.linkShare.type === SharingLinkType.Edit
+              ? DateTime.now().plus({ years: 3 }).endOf('day')
+              : null
         }),
         onConfirm: (expirationDateTime: DateTime) => {
           emit('updateLink', {
@@ -214,18 +218,21 @@ export default defineComponent({
           method: showDatePickerModal
         })
 
-        result.push({
-          id: 'remove-expiration',
-          title: $gettext('Remove expiration date'),
-          icon: 'calendar-close',
-          method: () => {
-            emit('updateLink', {
-              linkShare: { ...props.linkShare },
-              options: { expirationDateTime: null }
-            })
-            unref(editPublicLinkDropdown).hide()
-          }
-        })
+        // only if is not a edit folder link
+        if (!(props.linkShare.type === SharingLinkType.Edit && resource.value.isFolder)) {
+          result.push({
+            id: 'remove-expiration',
+            title: $gettext('Remove expiration date'),
+            icon: 'calendar-close',
+            method: () => {
+              emit('updateLink', {
+                linkShare: { ...props.linkShare },
+                options: { expirationDateTime: null }
+              })
+              unref(editPublicLinkDropdown).hide()
+            }
+          })
+        }
       } else if (!unref(isInternalLink)) {
         result.push({
           id: 'add-expiration',

packages/web-pkg/src/components/CreateLinkModal.vue

@@ -48,6 +48,9 @@
       v-if="isAdvancedMode"
       class="oc-mt-s"
       :min-date="DateTime.now()"
+      :max-date="
+        isFolder && selectedType === 'edit' ? DateTime.now().plus({ years: 3 }).endOf('day') : null
+      "
       :label="$gettext('Expiry date')"
       @date-changed="onExpiryDateChanged"
     />
@@ -303,6 +306,13 @@ export default defineComponent({
 
     const updateSelectedLinkType = (type: SharingLinkType) => {
       selectedType.value = type
+      onExpiryDateChanged({
+        date: unref(selectedExpiry),
+        error:
+          unref(selectedExpiry)?.toISO() > DateTime.now().plus({ years: 3 }).endOf('day').toISO() &&
+          isFolder &&
+          unref(selectedType) === 'edit'
+      })
     }
 
     onMounted(() => {