chore: refactor ingestion lambda to use loader function from @jsii/spec #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
commented
Jun 30, 2022
| parsedAssembly = validateAssembly( | ||
| JSON.parse(dotJsii.toString('utf-8')) | ||
| ); | ||
| parsedAssembly = loadAssemblyFromBuffer(dotJsii, compDotJsii); |
There was a problem hiding this comment.
This is the magic jsii function in question. I find this the most reasonable thing to do because we already have a mechanism in place (extractObjects) that can parse the .jsii and possible .jsii.gz file. Writing loadAssemblyFromTarball will result in a redundant copy of a lot of extractObjects' logic. Best of all, this way, we only parse the tarball once.
mergify bot
pushed a commit
to aws/jsii
that referenced
this pull request
Jul 6, 2022
Usage is demonstrated here: cdklabs/construct-hub#920 Two implementations were considered to fit the use case in construct hub, `loadAssemblyFromBuffer` and `loadAssemblyFromTarball`. I went with loading from a buffer because it allows us to utilize prior art in construct hub for parsing tarballs, does not need an added dependency on `tar`, and causes minimal impact when refactoring the ingestion lambda to use this function. Also includes a small refactoring of the test suite. --- By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license]. [Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
Signed-off-by: github-actions <[email protected]>
RomainMuller
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
loadAssemblyFromBuffer, a new function available in jsii v1.62.0.This refactor does not break any current tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license